Cleanup discord integration code #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the code for each interaction for a command is defined in the original command file instead of one big file that implements the logic for all commands.
The challenges-talk channel is the only channel that does not have a Discord bot message in it, so we should include everything in the channel.
These command implementations are a specific implementation of handling interaction, so it should not be in the global folder.
When we want to introduce new ways of interacting with Discord, we need to separate the current 'agile' implementation with everything else. This folder structure makes much more sense therefore.
In the future we want to be able to change the handle style of the Discord bot (see #239). Now we have an easy way of adding new handle styles which can be toggled by .env configuration. Only the discordHooks.ts needs to be split and reorganized for this to fully work.
The channels.ts file is created with the agile workflow in mind. Therefore it belongs to the agile subdirectory and it is not a general utility file.
Just like the commands and interactions, the hooks are now also dynamically imported.
This reduces the cognitive complexity a lot and allows for more reusable setup.
It makes more sense to have this function here than in the hooks.ts since it is related to solving a task and not for hooking.
|
I tested it locally and it works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Discord integration code is quite a mess. This PR reorganizes the code of the Discord bot to be easier to understand. Furthermore, it should prepare for different Discord channel handling styles so we can easily implement configurable styles of channel handling.