Parser logic improvements #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we just try to parse the input with each parser, ignoring errors. Then we select the parser with the most parsed challenges, except for some conditions with the raw parser. The raw parser will see every newline as a new task and when pasting a beautified JSON object, it should not be the best parser when other parsers also detect challenges.
An array is expected for the categories of justCTF tasks.
Not in use anymore so we can safely drop it.
Due to dropping the `isValid` function, these imports are not used anymore.
|
This looks good to me with a tiny issue, right now it's difficult to scan le number of tasks parsed by each parser, is it possible to add a |
Processed feedback from B-i-t-K (#313 (comment))
|
@B-i-t-K, like this? Pulling the counter to the right in the selected field looks a bit ugly because it cannot align with the other numbers due to the dropdown arrow. And it will always duplicate since the item selected is also in the list already.
|
|
perfect 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we just try to parse the input with each parser, ignoring errors. Then we select the parser with the most parsed challenges, except for some conditions with the raw parser. The raw parser will see every newline as a new task and when pasting a beautified JSON object, it should not be the best parser when other parsers also detect challenges.
The
isValidfunction is now dropped which simplifies creating a parser.This PR implements the logic as described in #269 (comment).
Screenshots:
