Merge docker-compose.prebuild.yml into docker-compose.yml #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Docker Compose allows to force self-build (using `--build`) or pull by default, it does not seem to make sense to separate two docker-compose.yml files.
JJ-8
added a commit
to JJ-8/CTFNote
that referenced
this pull request
Feb 23, 2024
Downstream PR from TFNS#232. Slightly changed the README for better copy paste.
|
Thanks @erdnaxe! Didn't know that Docker would ignore the hosted images when using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Docker Compose allows to force self-build (using
--build) or pull by default, it does not seem to make sense to separate two docker-compose.yml files.This pull request proposes to merge the ".prebuild.yml" variant with the main "docker-compose.yml".