API: Pin dicer to v0.3.1 #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current fix required to edit the lock file by hand. This commit adds a "resolutions" key to the package.json file. This pins this specific dependency to version 0.3.1 without using dubious hacks. More info about this feature: https://classic.yarnpkg.com/lang/en/docs/selective-version-resolutions/
JJ-8
approved these changes
Aug 24, 2022
There was a problem hiding this comment.
Good to hear that there is a proper solution for this.
On a different topic : can you rebase PR instead of merging them ? (Click on the downward-pointing arrow before merging)
This makes a prettier git history
Sure! I am used to explicit merges, but rebasing is also fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current fix required to edit the lock file by hand.
This commit adds a "resolutions" key to the package.json file.
This pins this specific dependency to version 0.3.1 without using dubious hacks.
More info about this feature:
https://classic.yarnpkg.com/lang/en/docs/selective-version-resolutions/
On a different topic : can you rebase PR instead of merging them ? (Click on the downward-pointing arrow before merging)
This makes a prettier git history