Task list for small screen sizes #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old hash pointed to a non-existing container. I have updated it to the correct hash: https://quay.io/repository/hedgedoc/hedgedoc/manifest/sha256:8df47646f2c58959921d2b7719a6f3023441bdb7435040aa3c32abe6145095f6 for both production and development. Moreover, the api did not work due to an outdated version of ts-node and typescript. This could be due to running a different node version locally on my machine. However, running it in Docker now also works.
Now the task dropdown is also visible when you have your browser resized to half your screen size. With usernames of normal length, this does not cause an overflow of the menu bar.
XeR
approved these changes
Aug 8, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the task list dropdown is also visible on smaller screen sizes. This is useful when the browser is on half your screen width:
Fullscreen:
Halfscreen:
Moreover, the (development) setup was broken, so I fixed the container hash and the dependencies.