Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build wheel for Python 3.9 #79

Merged
merged 1 commit into from
Aug 17, 2021
Merged

build wheel for Python 3.9 #79

merged 1 commit into from
Aug 17, 2021

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Aug 17, 2021

Avoid compilation when installing with pip on Python 3.9. See #78

@efiring
Copy link
Member

efiring commented Aug 17, 2021

I think we should drop 3.6 while adding 3.7, shouldn't we?

@ocefpaf
Copy link
Member Author

ocefpaf commented Aug 17, 2021

I think we should drop 3.6 while adding 3.7, shouldn't we?

Makes sense. We already dropped 3.6 from testing. Although we do build with an old numpy for "forward compatibility."

I'm just waiting for the tests to pass to make the GHA run only on published tags. We'll have to issue a .post0 version to generate the wheel.

@DocOtak
Copy link
Contributor

DocOtak commented Aug 17, 2021

Would it make sense to follow NEP 29 re python/numpy support?

@ocefpaf ocefpaf marked this pull request as ready for review August 17, 2021 23:48
@ocefpaf
Copy link
Member Author

ocefpaf commented Aug 17, 2021

Would it make sense to follow NEP 29 re python/numpy support?

We kind of do already. numpy 1.18 was dropped this past month but we don't have to rush to 1.19 just yet. Note that the users will get the latest numpy, just the build is with an old one to ensure compatibility.

We can move to 1.19 when we have a new release of gsw, in a way, we are just "catching up" with old releases here by building the wheels.

@ocefpaf ocefpaf requested a review from efiring August 17, 2021 23:52
Copy link
Member

@efiring efiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, passes the tests.

@efiring efiring merged commit 69a903b into TEOS-10:master Aug 17, 2021
@ocefpaf ocefpaf deleted the py39-wheel branch August 17, 2021 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants