Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return None type in return_xxx async api in Python #475

Merged
merged 1 commit into from
Dec 26, 2024
Merged

fix: return None type in return_xxx async api in Python #475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions core/src/ten_runtime/binding/python/interface/ten/async_ten_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,7 @@ async def send_audio_frame(
error = await q.get()
return error

async def return_result(
self, result: CmdResult, target_cmd: Cmd
) -> Optional[TenError]:
async def return_result(self, result: CmdResult, target_cmd: Cmd) -> None:
q = asyncio.Queue(maxsize=1)
self._internal.return_result(
result,
Expand All @@ -133,11 +131,11 @@ async def return_result(
)

error = await q.get()
return error

async def return_result_directly(
self, result: CmdResult
) -> Optional[TenError]:
if error is not None:
raise RuntimeError(error.err_msg())

async def return_result_directly(self, result: CmdResult) -> None:
q = asyncio.Queue(maxsize=1)
self._internal.return_result_directly(
result,
Expand All @@ -148,7 +146,9 @@ async def return_result_directly(
)

error = await q.get()
return error

if error is not None:
raise RuntimeError(error.err_msg())

async def get_property_to_json(self, path: str) -> str:
q = asyncio.Queue(maxsize=1)
Expand Down
Loading