Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refine C++ binding #457

Merged
merged 3 commits into from
Dec 24, 2024
Merged

refactor: refine C++ binding #457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e78a538
refactor: refine C++ binding
halajohn Dec 24, 2024
51b43d6
refactor: refine C++ binding
halajohn Dec 24, 2024
30477f2
refactor: refine C++ binding
halajohn Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/include/ten_runtime/binding/cpp/detail/extension.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class extension_t {
// @}

protected:
explicit extension_t(const std::string &name)
explicit extension_t(const char *name)
: // In order to keep type safety in C++, the type of the 'ten'
// parameters of these 4 functions are indeed 'ten::ten_env_t'.
// However, these callback functions are called from the C language
Expand All @@ -65,7 +65,7 @@ class extension_t {
// the second parameter of these callback functions from '::ten_env_t
// *' to 'void *'
c_extension(::ten_extension_create(
name.c_str(),
name,
reinterpret_cast<ten_extension_on_configure_func_t>(
&proxy_on_configure),
reinterpret_cast<ten_extension_on_init_func_t>(&proxy_on_init),
Expand Down
Loading
Loading