Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: convert the protocol creation api to pure async operation #220

Merged
merged 12 commits into from
Nov 1, 2024

Conversation

sunxilin
Copy link
Collaborator

No description provided.

@sunxilin sunxilin requested a review from halajohn as a code owner October 31, 2024 08:41
@sunxilin sunxilin linked an issue Oct 31, 2024 that may be closed by this pull request
@sunxilin sunxilin force-pushed the 128-convert-the-protocol-api-to-pure-async-operation branch from f1797dc to e893f34 Compare October 31, 2024 09:44
@sunxilin
Copy link
Collaborator Author

This pull request includes significant changes to the TEN Framework to simplify the addon and protocol management by removing asynchronous instance creation and destruction functions and adding new protocol-related structures and functions.

Simplification of Addon Management:

  • Removed asynchronous instance creation and destruction functions and replaced them with synchronous versions in core/include/ten_runtime/addon/addon.h.
  • Removed related asynchronous functions and structures from core/include_internal/ten_runtime/addon/addon.h. [1] [2] [3]
  • Updated the addon initialization and creation functions to use the new synchronous instance functions in core/src/ten_runtime/addon/addon.c. [1] [2] [3]

Protocol Management Enhancements:

  • Added new structures and functions for protocol creation and management in core/include_internal/ten_runtime/addon/protocol/protocol.h. [1] [2]
  • Introduced new protocol-related callback and info structures in core/include_internal/ten_runtime/engine/internal/remote_interface.h. [1] [2]
  • Added protocol-related functions and structures to handle protocol creation completion in core/include_internal/ten_runtime/app/on_xxx.h and core/include_internal/ten_runtime/engine/on_xxx.h. [1] [2] [3]

Miscellaneous Changes:

  • Removed deprecated functions related to extension creation and destruction in core/include/ten_runtime/addon/extension/extension.h. [1] [2]
  • Updated the ten_engine_t structure to include a reference to ten_env_t in core/include_internal/ten_runtime/engine/engine.h. [1] [2]
  • Removed deprecated protocol creation function in core/include/ten_runtime/protocol/protocol.h.
  • Simplified endpoint functions in core/include_internal/ten_runtime/app/endpoint.h.

@halajohn halajohn merged commit c174bc9 into main Nov 1, 2024
15 checks passed
@halajohn halajohn deleted the 128-convert-the-protocol-api-to-pure-async-operation branch November 1, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Convert the protocol API to pure async operation
2 participants