feat!: add SetFinal for cmd result in go #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, unify the naming convention for state-type APIs to use `set_<foo>` and `is_<foo>` across all languages, including C++, Python, and Go. For example, `set_eof`/`is_eof`, `set_final`/`is_final` follow this pattern. BREAKING CHANGE: Places that originally used `set_is_final` and `set_is_eof` need to be changed to `set_final` and `set_eof`.
halajohn
deleted the
82-golang-cmdresult-doesnt-have-setisfinal-api-which-is-available-on-python
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, unify the naming convention for state-type APIs to use
set_<foo>andis_<foo>across all languages, including C++, Python, and Go.For example,
set_eof/is_eof,set_final/is_finalfollow this pattern.BREAKING CHANGE: Places that originally used
set_is_finalandset_is_eofneed to be changed toset_finalandset_eof.