add fashionai #329
Merged
add fashionai #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove appId
1. change asyncio.run to asyncio.run_coroutine_threadsafe 2. maybe put wihle true in async_polly_handler
change method name to create_task
add fashionai graph
1. separate FashionAIClient 2. add try catch to asyncio.run_coroutine_threadsafe when timeout 3. define attributes in class directly
plutoless
reviewed
Oct 12, 2024
plutoless
reviewed
Oct 12, 2024
1. change method name to create_task 2. put queue timeout add log
plutoless
approved these changes
Oct 12, 2024
rollback method name
2. Add FashionAIClient to separated file 3. Fix event loop handling and ensure proper coroutine execution in on_stop method
plutoless
approved these changes
Oct 13, 2024
tomasliu-agora
requested changes
Oct 14, 2024
agents/ten_packages/extension/fashionai/src/fashionai_client.py
Outdated
Show resolved
Hide resolved
tomasliu-agora
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.