feat: improve first time loading experience, only enable Join button until it's fully functional #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangpostkarte
changed the title
tangpostkarte
changed the title
tangpostkarte
changed the title
tangpostkarte
changed the title
|
@tangpostkarte Thanks for the PR. Adding the following state, isn't that right? 
|
cyfyifanchen
approved these changes
Sep 30, 2024
cyfyifanchen
added
enhancement
|
Yes, we adding loading ... since it's not Joinable when loading. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the login page is loaded, clicking join will not respond and the loading text will be displayed #297