Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use message_collector to replace chat_transcriber #248

Merged
merged 1 commit into from
Aug 24, 2024
Merged

feat: use message_collector to replace chat_transcriber #248

merged 1 commit into from
Aug 24, 2024

Conversation

plutoless
Copy link
Contributor

  • add a new message_collector
  • replace chat_transcriber and take out cmd_conversion
  • UI adapt

@plutoless
feat: use message_collector to replace chat_transcriber
3abd217 
- add a new message_collector
- replace chat_transcriber and take out cmd_conversion
- UI adapt
wangyoucao577
wangyoucao577 reviewed Aug 24, 2024
View reviewed changes
Copy link
Collaborator

@wangyoucao577 wangyoucao577 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the old chat_transcriber and chat_transcriber_python will be useless and can be removed directly?

agents/property.json
@@ -65,8 +65,8 @@
{
"type": "extension",
"extension_group": "transcriber",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extension_group can be renamed either

agents/ten_packages/extension/message_collector/src/extension.py Show resolved Hide resolved
@plutoless plutoless merged commit 6ab123a into main Aug 24, 2024
1 check passed
@plutoless plutoless deleted the feat/message-collector branch August 24, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangyoucao577 wangyoucao577 wangyoucao577 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plutoless @wangyoucao577