-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Session Copy Modal: Instructors able to select the Course that they are copying from #12552
Comments
@rexong Fair point! This lies in the UX, or maybe the relationship between a Course and Feedback Session. The suggestions that you've provided are good. We could also allow them to select the same session but if the same session already exists, perhaps we could have them make some changes for differentiation. My understanding might not be 100% accurate on this. Let's hear what the rest thinks 👍🏻 |
@rexong copying a session to the same course is a legit use case e.g. to reuse the same set of questions multiple times in the same course. The user is expected to change to session name (which is editable) in the 'copy session' dialog first. |
I am clearer about the use case now. Currently, if the user did not change the session name and tried to copy the session again, the error toast pops up stating that the current session already exist in the course.
|
I agree.
This could be misleading, as it gives the impression that the action is not allowed.
Do you mean when the user clicks the |
I was initially thinking of informing the user using the error toast (not staying in the dialog). |
Environment:
master
branch at commit8633d4e
Steps to reproduce
Given that there is a session call
First team feedback session (percentage-based)
fromtest.tes-demo
course.Copy
button ofFirst team feedback session (percentage-based)
test.tes-demo
as the course to copy to.Video Demo
TEAMMATES.-.Online.Peer.Feedback_Evaluation.System.for.Student.Team.Projects.-.Google.Chrome.2023-08-09.22-14-20.mp4
Current behaviour
![image](https://private-user-images.githubusercontent.com/66376253/259444187-facef50e-e802-4ded-9405-1e3ddb3a0204.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ2NzQwNjMsIm5iZiI6MTcyNDY3Mzc2MywicGF0aCI6Ii82NjM3NjI1My8yNTk0NDQxODctZmFjZWY1MGUtZTgwMi00ZGVkLTk0MDUtMWUzZGRiM2EwMjA0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI2VDEyMDI0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWYyOTQxOWRjYzUxYTc0ZmU2MmUyNWUxMTJkMWM2ZTU4Mjg2N2FhMTJkOWU3ZTNiMjdiYzIzYmQ0NTk3ZDcwMGEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.X1D5-KNquiN_lMXrWwd9MPDkCnq2Y0wqQ0x7e2Kg5Z4)
Error will be shown stating that the session is already in the course.
Suggestions
Perhaps the instructor should not be allowed to copy the session into the same course.
This could be resolved by either
The text was updated successfully, but these errors were encountered: