Skip to content

feat(Popup): 添加实例方法 getPopper 获取 popper 实例 #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 30, 2025
Merged

feat(Popup): 添加实例方法 getPopper 获取 popper 实例 #751

merged 7 commits into from
Oct 30, 2025

Conversation

@RSS1102
Copy link
Collaborator

@RSS1102 RSS1102 commented Oct 28, 2025 •
edited
Loading

@RSS1102 RSS1102 changed the title feat(Popup): 添加实例方法 `` 获取 popper 实例 feat(Popup): 添加实例方法 getPopper 获取 popper 实例 Oct 28, 2025
@RSS1102 RSS1102 mentioned this pull request Oct 28, 2025
Merged
16 tasks
@RSS1102 RSS1102 marked this pull request as draft October 29, 2025 03:54
@RSS1102 RSS1102 marked this pull request as ready for review October 29, 2025 06:35
@RSS1102
Copy link
Collaborator Author

RSS1102 commented Oct 29, 2025

image

@liweijie0812
Copy link
Member

liweijie0812 commented Oct 29, 2025 •
edited
Loading

类型 https://github.com/floating-ui/floating-ui/blob/92195083958c9496988ed4526b82b75b7256b5a4/src/createPopper.js#L45

https://github.com/floating-ui/floating-ui/blob/92195083958c9496988ed4526b82b75b7256b5a4/src/types.js#L119

@RSS1102
Copy link
Collaborator Author

RSS1102 commented Oct 29, 2025 •
edited
Loading

不过看起来返回值为 Instance | null 看起来更合理一点？

@RSS1102
Copy link
Collaborator Author

RSS1102 commented Oct 29, 2025

getOverlay 返回类型为 HTMLElement | null
getPopper 返回类型为 Instance | null

@liweijie0812 liweijie0812 merged commit 00bb86c into main Oct 30, 2025
4 checks passed
@liweijie0812 liweijie0812 deleted the rss1102/feat/popup/get-popper branch October 30, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liweijie0812 liweijie0812 liweijie0812 approved these changes

@uyarn uyarn uyarn approved these changes

@chaishi chaishi Awaiting requested review from chaishi chaishi is a code owner

@anlyyao anlyyao Awaiting requested review from anlyyao anlyyao is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RSS1102 @liweijie0812 @uyarn