Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update style guide #7

Merged
merged 2 commits into from
Mar 18, 2025
Merged

update style guide #7

merged 2 commits into from
Mar 18, 2025

Conversation

supsm
Copy link
Contributor

@supsm supsm commented Mar 17, 2025

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
README.md Outdated
- Indent with 4 spaces
- Braces on the same line
- Pointers/references on the left
- Indent with one tab character
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice try. You see, another reviewer might have missed this and merged it but I have eagle eyes and you'll never sneak anything past me!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wasn't trying to sneak anything, "update" means things are changed

@michael-kenzel michael-kenzel self-requested a review March 18, 2025 01:55
Copy link
Collaborator

@nickclark2016 nickclark2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces for cross browser consistency. I agree with left pointer/reference placement, and don't have strong opinions on the brace placement as long as it's consistent.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@jeremy-rifkin jeremy-rifkin merged commit a6698a7 into TCCPP:main Mar 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants