Introduce bot modules, move TCCPP-specific components into tccpp module #136
Conversation
.gitmodules
Outdated
| [submodule "wheatley-private"] | ||
| path = src/wheatley-private | ||
| [submodule "src/components/tccpp/private"] | ||
| path = src/components/tccpp/private |
There was a problem hiding this comment.
I had forgotten that wheatley-private isn't just components, it's
algorithm/
components/
services/
test/
Thoughts on keeping this top-level? Maybe moving src/components/tccpp to src/tccpp/components? Not sure what's best.
There was a problem hiding this comment.
We could have bot modules—libraries of related components and their infrastructure—that can be installed in src/modules. And then we just load components from src/**/components/*.ts.
michael-kenzel
force-pushed
the
restructuring
branch
4 times, most recently
from
0e82bba to
31a93d8
Compare
michael-kenzel
force-pushed
the
restructuring
branch
from
31a93d8 to
b981949
Compare
michael-kenzel
changed the title
michael-kenzel
changed the title
src/components/wiki.ts
Outdated
| const name = path.basename(file_path, path.extname(file_path)); | ||
| const content = await fs.promises.readFile(file_path, { encoding: "utf-8" }); | ||
| for await (const file_path of globIterate("wiki/articles/**/*.md", { withFileTypes: true })) { | ||
| const name = file_path.name.slice(0, -3); |
There was a problem hiding this comment.
I would prefer this to remain in terms of path operations if possible, it’s a lot clearer than a splice
There was a problem hiding this comment.
I would actually suggest just using the file name here, it seems to only be used as an internal identifier anyways, everything seems to work fine with just file_path.name instead.
| @@ -395,25 +395,16 @@ export class Wheatley { | |||
| })().catch(this.critical_error.bind(this)); | |||
| }); | |||
|
|
|||
| for await (const file of walk_dir("src/components")) { | |||
| const default_export = (await import(`../${file.replace(".ts", ".js")}`)).default; | |||
| for await (const file of globIterate("**/components/*.js", { | |||
There was a problem hiding this comment.
I’m a bit concerned about globbing every js file in any components/ folder here. Would be better to make sure this is in the dist folder or whatnot.
There was a problem hiding this comment.
The cwd: import.meta.dirname should constrain it to only take .js files from components subdirectories of the src/ directory.
test/wiki-articles.ts
Outdated
| } | ||
| const name = path.basename(file_path, path.extname(file_path)); | ||
| for (const file_path of globSync("wiki/articles/**/*.md", { withFileTypes: true })) { | ||
| const name = file_path.name.slice(0, -3); |
michael-kenzel
force-pushed
the
restructuring
branch
from
d8acadd to
35dc897
Compare
michael-kenzel
force-pushed
the
restructuring
branch
from
35dc897 to
8bd6841
Compare
|
Take a first step in untying Wheatley from TCCPP by introducing bot modules and moving TCCPP stuff into a
tccppmodule. Also introduces anexcludesconfig option to skip loading certain components, and replaces our customwalk_dir()with theglobpackage.