Automated release pipeline #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leordev
force-pushed
the
leordev/autoreleases
branch
3 times, most recently
from
c437a6b
to
cbd190a
Compare
leordev
force-pushed
the
leordev/autoreleases
branch
from
cbd190a
to
8b7b011
Compare
leordev
force-pushed
the
leordev/autoreleases
branch
from
2323bee
to
1bf3b37
Compare
leordev
force-pushed
the
leordev/autoreleases
branch
from
17c0770
to
bbb3168
Compare
amika-sq
approved these changes
Feb 23, 2024
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 100 |
There was a problem hiding this comment.
Curious if we can/should reduce this. Would we be able to get away with 1 here?
There was a problem hiding this comment.
I did a little research and I think the best we can get away with is by using filter: tree:0:
actions/checkout#1152 (comment)
The reason is that we need the history to be able to figure out the latest git tag. A shallow clone unfortunately does not give us that.
Maybe we can reduce the depth to 50, or 25 assuming that we will always cut new releases when we are about 50 or 25 merged PRs. WDYT?
There was a problem hiding this comment.
Gotcha! I think it's fine to leave at 100 then, as that should usually contain the last tag. Probably a bit better to overestimate than under :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working Evidence: https://github.com/TBD54566975/web5-swift/releases/tag/0.0.3-test (let's remove it before merging it!)