Close message type
#110
Merged
Close message type
#110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistermoe
requested review from
michaelneale,
jiyoontbd and
phoebe-lew
as code owners
KendallWeihe
reviewed
Jul 5, 2023
| | `reason` | string | N | an explanation of why the thread is being closed | | ||
|
|
||
| ## `Quote` | ||
| > PFI -> Alice: "OK, here's your Quote that describes how much BTC you will receive based on your RFQ. Here's the total fee in USD associated with the payment methods you selected. Here's how to pay us, and how to let us pay you, when you're ready to execute the Quote. This quote expires at X time." |
There was a problem hiding this comment.
Nice, I dig the natural language sample as an explainer
There was a problem hiding this comment.
props to @phoebe-lew and @jiyoontbd here!
KendallWeihe
approved these changes
Jul 5, 2023
phoebe-lew
approved these changes
Jul 5, 2023
phoebe-lew
added a commit
that referenced
this pull request
Jul 6, 2023
* Rename presentationRequest to presentationDefinition * Yeet the protocol folder * Yeet the implementations folder * `Close` message type (#110) --------- Co-authored-by: Moe Jangda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
went ahead and added in a
Closemessage type so we could take a look at it.