feat: language plugins require a bind allocator to be provided #3069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt2e
force-pushed
the
matt2e/plugins-need-bind-allocator
branch
from
24278b1
to
717b2a9
Compare
Open
matt2e
commented
Oct 10, 2024
| @@ -1,7 +1,7 @@ | |||
| env = { | |||
| "DBMATE_MIGRATIONS_DIR": "${HERMIT_ENV}/backend/controller/sql/schema", | |||
| "DBMATE_NO_DUMP_SCHEMA": "true", | |||
| "FTL_ENDPOINT": "http://localhost:8892", | |||
| "FTL_ENDPOINT": "http://127.0.0.1:8892", | |||
There was a problem hiding this comment.
This prevents MacOS from showing alert dialogs for incoming connections
matt2e
force-pushed
the
matt2e/plugins-need-bind-allocator
branch
from
d50685e
to
6e63007
Compare
alecthomas
approved these changes
Oct 10, 2024
matt2e
force-pushed
the
matt2e/plugins-need-bind-allocator
branch
from
6e63007
to
1f7c673
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for external language plugins. This PR makes sure
languageplugin.New()is called with a bind allocator so that external plugins will soon able to able to acquire a bind url.