Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduced ResumableTaskStore and ResumableTaskManager #749

Merged
merged 11 commits into from
Jun 11, 2024
Merged

Introduced ResumableTaskStore and ResumableTaskManager #749

merged 11 commits into from
Jun 11, 2024

Conversation

thehenrytsai
Copy link
Member

  1. Introduced ResumableTaskStore interface and its level implementation.
  2. Introduced ResumableTaskManager.
  3. Refactoring to RecordsDelete handler.

@thehenrytsai thehenrytsai marked this pull request as draft June 3, 2024 18:22
@thehenrytsai thehenrytsai changed the title Henrytsai/resumable task store Introduced ResumableTaskStore and ResumableTaskManager Jun 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.57%. Comparing base (40567c9) to head (d6701b7).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #749      +/-   ##
==========================================
+ Coverage   98.53%   98.57%   +0.04%     
==========================================
  Files          71       73       +2     
  Lines       10646    10945     +299     
  Branches     1548     1579      +31     
==========================================
+ Hits        10490    10789     +299     
  Misses        150      150              
  Partials        6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

csuwildcat
csuwildcat previously approved these changes Jun 4, 2024
View reviewed changes
@thehenrytsai thehenrytsai marked this pull request as ready for review June 5, 2024 02:22
LiranCohen
LiranCohen previously approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible work! Very clean and simplistic implementation that gets the job down. 🐐

Just a small comment that could add some clarity for readers, but otherwise LGTM!

tests/features/resumable-tasks.spec.ts Show resolved Hide resolved
src/store/resumable-task-store-level.ts Outdated Show resolved Hide resolved
LiranCohen
LiranCohen previously approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

LiranCohen
LiranCohen approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@thehenrytsai thehenrytsai merged commit 0311b9e into main Jun 11, 2024
4 checks passed
@thehenrytsai thehenrytsai deleted the henrytsai/resumable-task-store branch June 11, 2024 22:16
@enmand enmand mentioned this pull request Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiranCohen LiranCohen LiranCohen approved these changes

@csuwildcat csuwildcat csuwildcat left review comments

@mistermoe mistermoe Awaiting requested review from mistermoe mistermoe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thehenrytsai @codecov-commenter @csuwildcat @LiranCohen