-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduced ResumableTaskStore
and ResumableTaskManager
#749
Conversation
ResumableTaskStore
and ResumableTaskManager
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #749 +/- ##
==========================================
+ Coverage 98.53% 98.57% +0.04%
==========================================
Files 71 73 +2
Lines 10646 10945 +299
Branches 1548 1579 +31
==========================================
+ Hits 10490 10789 +299
Misses 150 150
Partials 6 6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incredible work! Very clean and simplistic implementation that gets the job down. 🐐
Just a small comment that could add some clarity for readers, but otherwise LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙇
ResumableTaskStore
interface and itslevel
implementation.ResumableTaskManager
.RecordsDelete
handler.