-
Notifications
You must be signed in to change notification settings - Fork 399
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
replace most SDL_SetHint calls with SDL_SetHintWithPriority
ensures calls actually do something and won't be ignored due to env vars
- Loading branch information
1 parent
9f3630c
commit 6578c85
Showing
3 changed files
with
5 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6578c85
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is a response to some broken behavior? I just wonder what could go wrong with the previous code in case this could come up elsewhere or later again.
6578c85
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #1430 (comment)
Env vars have SDL_HINT_OVERRIDE priority, so simple SDL_SetHint calls won't affect them.
6578c85
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm alright, but is this the "correct" thing to do then? Like should we be forcefully ignoring env vars that set SDL hints?
6578c85
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For cases where it doesn't make sense to allow the user to override the setting regardless (and potentially will just lead to broken behavior if our hints are not respected) sure.