chore(core-styles): v0.6.0-beta #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyboar
changed the title
This was referenced Jun 8, 2022
wesleyboar
commented
Jun 8, 2022
Comment on lines
+147
to
+151
| [unreleased]: https://github.com/TACC/Core-Styles/compare/v0.6.0-beta...HEAD | ||
| [0.6.0-beta]: https://github.com/TACC/Core-Styles/releases/tag/v0.6.0-beta | ||
| [0.6.0-alpha.2]: https://github.com/TACC/Core-Styles/releases/tag/v0.6.0-alpha.2 | ||
| [0.6.0-alpha.1]: https://github.com/TACC/Core-Styles/releases/tag/v0.6.0-alpha.1 | ||
| [0.6.0-alpha]: https://github.com/TACC/Core-Styles/releases/tag/v0.6.0-alpha |
There was a problem hiding this comment.
Uh oh. These URLs are wrong (see TACC/Core-Styles). Plan needed.
- remove callout that only cms uses this - add portal to related repo
* fix(tup-ui): load CSS from correct path * chore(tup-ui): format:write * fix(tup-ui): more CSS path fixes * Fix pipeline by building dist/core-components * Fix pipeline by building dist/core-styles Co-authored-by: Joon-Yee Chuah <[email protected]>
These steps were based on Core-Styles in its own repo, where it had tags from which `git describe` could produce a build ID. No tags in new repo, so simpler default build step, and do not mention `git describe`.
wesleyboar
force-pushed
the
task/styles-version-bump
branch
from
0fac75a
to
48e4d3e
Compare
wesleyboar
changed the title
The npm publish process runs build step.
jchuahtacc
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Update core-styles version to
0.6.0-beta.Related:
Changes:
Testing:
UI:
N/A
Notes:
Let's talk about versioning.
Core-Styles
Early on (i.e. until there is an automated Pattern Library to test with), I want to publish (to NPM) Styles versions without waiting for TUP-UI version bump, so I can use the new versions in Core-CMS and Core-Portal. I can deploy
alphaandbetaversions of Styles to NPM for such scenarios. And once CMS and/or Portal have tested a Styles version (atalphaorbeta) i.e. merged a PR with the new version, then Core-Styles can get a proper version (noalphanobeta).This Whole Repo
As a whole, not just the TUP-UI app, nor any one lib. If there is one version to rule them all, I will change Core-Styles to match. But I may still suggest
alpha/betatagging so I can version Styles changes that need to be tested.