Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: WI-154 show field labels not keys #483

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Sep 17, 2024

Overview

In "Tour Request Form" response:

  • do show field labels
    which are for users
  • not field name keys
    which are for code

Related

Changes

  • changed field value name shown to user in e-mail
  • removed recaptcha field value

Testing

  1. Have a form called "Tour Request Form".
  2. Submit form.
  3. Verify auto-reply:
    • does not show reCAPTCHA value
    • shows "First Name" not first-name
    • shows "Name of Your Organization" not name-of-your-organization
    • et cetera

UI

Before After
WI-154 Email Top (BEFORE) WI-154 Email Top (AFTER)
WI-154 Email End (BEFORE) WI-154 Email End (AFTER)

@wesleyboar wesleyboar marked this pull request as ready for review October 3, 2024 18:56
@wesleyboar wesleyboar requested review from van-go, sophia-massie and jarosenb and removed request for van-go October 3, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant