Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Actions and PR template #3

Merged
merged 4 commits into from
Jun 3, 2022
Merged

Add Github Actions and PR template #3

merged 4 commits into from
Jun 3, 2022

Conversation

jarosenb
Copy link
Collaborator

@jarosenb jarosenb commented Jun 3, 2022

Adds Github housekeeping.

@jarosenb jarosenb requested a review from jchuahtacc June 3, 2022 15:11
Copy link
Member

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Optional change suggestions.) I will suggest these simplification of PR templates for Portal, too. I made similar simplifications in CMS, and just suggested them for Portal. I find fewer words allow easier skimming. I'll update all three to match if we come to agreement.

.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jchuahtacc jchuahtacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jarosenb jarosenb merged commit 14e00c1 into main Jun 3, 2022
@wesleyboar wesleyboar deleted the nx-ci branch June 22, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants