57 create library for flags for all the different python scripts #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenlienharrell
requested changes
Sep 25, 2024
tacc_stats.ini
Outdated
| data_dir = /tacc_stats_site/%(machine)s | ||
| server = tacc-stats02.tacc.utexas.edu | ||
| server = tacc-stats04.tacc.utexas.edu |
There was a problem hiding this comment.
Make this generic in the main tree
tacc_stats.ini
Outdated
| dbname = test_db | ||
| daily_archive_dir = %(data_dir)s/daily_archive | ||
| engine_name = django.db.backends.postgresql_psycopg2 | ||
| username = taccstats |
There was a problem hiding this comment.
change the taccstats user/pass to user and pass
tacc_stats/analysis/gen/jid_table.py
Outdated
| import psycopg2 | ||
| import tacc_stats.cfg as cfg | ||
| import conf_parser as cfg |
There was a problem hiding this comment.
Conf parser needs to be a full name under taccstats like the line below: from tacc_stats.analysis.gen.utils import read_sql
There was a problem hiding this comment.
This is a comment for every file
conf_parser.py
Outdated
| cfg = configparser.ConfigParser() | ||
|
|
||
| # Append your local repository path here: | ||
| cfg.read('/home/sg99/tacc_stats/tacc_stats.ini') |
There was a problem hiding this comment.
make this path non-absolute, we can talk about ways to do this.
tacc_stats/analysis/gen/jid_table.py
Outdated
|
|
||
| CONNECTION = cfg.get_db_connection_string() | ||
| print("SOMETHING SHOULD PRINT\n") |
There was a problem hiding this comment.
Remove debug statements
sanga1999
deleted the
57-create-library-for-flags-for-all-the-different-python-scripts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the new config parser library, along with updates to the ini file, and all files that read from the config parser.