Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: header use Roboto not Benton #470

Merged

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Mar 3, 2025

Overview

Use free font instead of paid font, because a free font is easier to replicate across clients.1

Related

Changes

  • changed font for header

Testing

  1. Open http://localhost:3000/components/detail/s-header--with-branding.
  2. Verify font is Roboto.

UI

Screenshot 2025-03-03 at 16 47 53

Notes

Footnotes

  1. TACC/Core-Portal has trouble loading Benton Sans font because of relative paths in Core-Styles and Vite asset handling in Core-Portal; TUP's solution failed on Core-Portal (i tested locally and left no paper trail).

A free font is easier to replicate across clients.
@wesleyboar wesleyboar merged commit 1acb870 into main Mar 3, 2025
@wesleyboar wesleyboar deleted the enhance/header-with-free-font-is-easier-to-replicate branch March 3, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant