Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: header font inconsistent between clients #464

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Mar 3, 2025

Overview

Header font should be explicit, so that it is consistent across clients.1

Related

Changes

  • changes font family and size from variable to certain

Testing

  1. Open http://localhost:3000/components/detail/s-header--with-branding.
  2. Verify font size is 14px.
  3. Verify font family is Benton Sans.

UI

Screenshot 2025-03-03 at 14 25 48

Footnotes

  1. Portal does not use the same global font family nor the same global font size medium as CMS.

Header font should be explicit, so that it is consistent across clients.[^1]

[^1]: Portal does not use the same global font family nor the same global font size medium.
@wesleyboar wesleyboar changed the title fix: header font was not explicit fix: header font inconsistent between clients Mar 3, 2025
@wesleyboar wesleyboar merged commit 287c4a9 into main Mar 3, 2025
@wesleyboar wesleyboar deleted the fix/header-font-should-be-explicit branch March 3, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant