Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simple explicit header nav link padding #461

Closed
wants to merge 7 commits into from
Closed

refactor: simple explicit header nav link padding #461

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
44107de
Revert "refactor: header__nav-link--tall → …--not-expanded"
wesleyboar Mar 1, 2025
31425c4
Revert "fix: different rems give diff header spacing"
wesleyboar Mar 1, 2025
62dd3ee
Revert "fix: some header styles not scoped with .s-header"
wesleyboar Mar 1, 2025
4414a8c
fix: some header styles not scoped with .s-header
wesleyboar Mar 1, 2025
e1cbe7f
fix: different rems give diff header spacing
wesleyboar Mar 1, 2025
87527e3
refactor: header__nav-link--tall → …--not-expanded
wesleyboar Mar 1, 2025
5504d3a
refactor: simplify header navlink padding
wesleyboar Mar 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions src/lib/_imports/trumps/s-header.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ Styleguide Trumps.Scopes.Header

/* If link text uses 2 lines, header grows taller (but it must not do so) */
white-space: nowrap;

padding: 5px 14px;
}

@define-mixin header--not-expanded {
Expand Down Expand Up @@ -144,19 +146,6 @@ Styleguide Trumps.Scopes.Header
color: var(--header-text-color);
}

/* Navigation: Links: Responsive Design */

/* Tweak Bootstrap `_nav.scss` (which selects via `navbar-expand-` class) */
.s-header[class*="navbar-expand-"] .navbar-nav .nav-link {
padding-right: 14px; /* NO-R/EM: .875rem (overwrite Bootstrap) */
padding-left: 14px; /* NO-R/EM: .875rem (overwrite Bootstrap) */
}

@media (--medium-and-below) {
.s-header[class*="navbar-expand-"] .navbar-nav .nav-link {
padding-block: 8px;
}
}

/* Search */

Expand Down