fix: WP-895 portal nav position wrong on portal #1071
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but works fine on cms
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1071 +/- ##
=======================================
Coverage 70.34% 70.34%
=======================================
Files 538 538
Lines 33328 33328
Branches 2953 2953
=======================================
Hits 23446 23446
Misses 9684 9684
Partials 198 198
Flags with carried forward coverage won't be shown. Click here to find out more. |
This was referenced Mar 3, 2025
shayanaijaz
added a commit
that referenced
this pull request
Mar 7, 2025
* Task/WP-76: Add unit tests for /api/accounts/systems/ route (#984) * Created systems.sagas.test.js, created a test for pushSystemKeys() * Updated expect() statement to correctly look for action.payload.onSuccess --------- Co-authored-by: Jeff McMillen <[email protected]> Co-authored-by: Jacob Lowe <[email protected]> * JS Warnings: Adjust button usage and pass in required fields (#973) * WP-701: ProjectId can be optional in DataFilesProjectMembers component. (#976) * Task/WP-53: Rename loading status fix (#980) * WP-53: Rename loading status fix * Fix undefined 'FilesListing' in DataFilesUploadModal * useRename state fix * Removed extra operation status call, added prettier,linting * Bug/WP-417: Onboarding User List Alternating Color (#985) * index based styling fix for alternating user rows * WP-417: Test for multiple actions per user have correct formatting * WP-417: Test for multiple actions per user have correct formatting + prettier * WP-417: Test for multiple actions per user have correct formatting + unused import removed * Bug/WP-420: Search placeholder does not update on navigating to directories (#989) * Changed from Root in placeholder to System Display Name * client side linting * Update client/src/components/DataFiles/DataFilesListing/DataFilesListing.jsx Co-authored-by: Sal Tijerina <[email protected]> --------- Co-authored-by: Sal Tijerina <[email protected]> * build(deps): bump werkzeug from 3.0.3 to 3.0.6 in /server (#990) Bumps [werkzeug](https://github.com/pallets/werkzeug) from 3.0.3 to 3.0.6. - [Release notes](https://github.com/pallets/werkzeug/releases) - [Changelog](https://github.com/pallets/werkzeug/blob/main/CHANGES.rst) - [Commits](pallets/werkzeug@3.0.3...3.0.6) --- updated-dependencies: - dependency-name: werkzeug dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Chandra Y <[email protected]> * Update CHANGELOG.md for 3.9.0 * deps/react-18: Update React to v18 (#979) * dependency updates * styling/test fixes * address security vulnerabilities in deps * regenerate package-lock.json * stylelint fixes * ignore css files when checking formatting * fix nav link flash on hover * fix for input-group and apps-grid styles * update react-query --------- Co-authored-by: Chandra Y <[email protected]> * WP-730: Refactor useRename to use react-query (#993) * refactor useRename to use react-query * fix tests * replace fetch call with axios client * Task/WP-78: V3 Shared Workspaces Tests (#987) * initial mock project create tests w/ formatting changes * test_project_init * Pivot to behavior based testing versus implementation based * test_project_init with mock tapis * prettier and pyright changes * test_project_create and generalized init mock * start listing * service account linting * todo comments * test_add_member * test formatting to match test_add_member * updated mock tapis for storage, disabled some tests temporarily later tests need the mock storage * linting and formatting * mock get for project storage * test_listing with storage * test_add_member init * update permissions in mock tapis * start rewrite from dict object to tapisresult object (simplify) * test_project_create new assert calls * test_project_create with TapisResult assertion * test_listing with TapisResult * add_member TapisResult * add_member - Mock updated project assertions * add_member_unauthorized TapisResult * new tests init * linting * workspace and patch helper functions * test_get_workspace_role * helper function 2 user shared workspace * change role, remove user, transfer owner, update * variable added for new username to add to system --------- Co-authored-by: Garrett Edmonds <[email protected]> * Bug/WP-50: Fix sizing of buttons "as-link" (#986) * Found settings that overruled font-size and adjusted font-size accordingly * Linted code to standardize code structure * Found root cause of button sizing issues and adjusted font-size accordingly * Added new CSS rule that only resizes as-link buttons to 1 rem * Update client/src/components/History/History.module.scss Removing commented-out code per Frank's recommendation Co-authored-by: fnets <[email protected]> * Update client/src/components/_common/Button/Button.module.css Removing commented-out code per Frank's recommendation Co-authored-by: fnets <[email protected]> * Update client/src/components/History/History.module.scss Removed commented-out code per Frank's recommendation Co-authored-by: fnets <[email protected]> --------- Co-authored-by: Jeff McMillen <[email protected]> Co-authored-by: fnets <[email protected]> Co-authored-by: Sal Tijerina <[email protected]> Co-authored-by: Garrett Edmonds <[email protected]> * Task/WP-509: Handle file/folder download feature with large number of files (#981) * Task/WP-509: Added functionality that prevents users from downloading files greater than 2 GB directly through TAPIS * Linted all code to pass linting tests * Fixed test that tests for alert preventing large downloads through TAPIS directly * Removed timestamped vite file, removed commented import statements * Ran Prettier again * Pushing up a failed test; can't get this to pass * Roll back jest-dom package update (out of scope of this PR) * Corrected test that verifies direct downloads of small files * Updated numbers in my code and tests to make them more readable * Added feature that prevents compression of files totaling more than 2 GB (but not folders) * Added functionality that prevents folder downloads altogether * Working on test for most recent code, test is incomplete * Added test that successfully prevents folder downloads * Still working on the final test, not passing yet * Successfully got all tests to pass * Linted front-end code * Created new large download modal, work in progress * Refined comments to push up new modal for debugging * Large Download Modal now properly closes as intended * Triggers Large Download Modal when user attempts to download multiple files totaling more than 2 GB * Added No Folders Modal to prevent folder downloads * Corrected failing test to prevent large file downloads * Added new tests to increase coverage, re-styled new modals * Increased test coverage even further * Even further increased test covered again * Update client/src/components/DataFiles/DataFilesModals/DataFilesNoFoldersModal.jsx Co-authored-by: Chandra Y <[email protected]> * Update client/src/components/DataFiles/DataFilesModals/DataFilesNoFoldersModal.jsx Co-authored-by: Chandra Y <[email protected]> * Update client/src/components/DataFiles/DataFilesModals/DataFilesNoFoldersModal.jsx Co-authored-by: Chandra Y <[email protected]> * Update client/src/components/DataFiles/DataFilesModals/DataFilesNoFoldersModal.jsx Co-authored-by: Chandra Y <[email protected]> * Update client/src/components/DataFiles/DataFilesModals/DataFilesDownloadMessageModal.jsx Co-authored-by: Chandra Y <[email protected]> * Update client/src/components/DataFiles/DataFilesModals/DataFilesDownloadMessageModal.jsx Co-authored-by: Chandra Y <[email protected]> * Update client/src/components/DataFiles/DataFilesModals/DataFilesDownloadMessageModal.jsx Co-authored-by: Chandra Y <[email protected]> * Removed superfluous comments * Removed whitespace to pass linting tests --------- Co-authored-by: Jeff McMillen <[email protected]> Co-authored-by: Garrett Edmonds <[email protected]> Co-authored-by: Jeff McMillen <[email protected]> Co-authored-by: Garrett Edmonds <[email protected]> Co-authored-by: Chandra Y <[email protected]> Co-authored-by: Sal Tijerina <[email protected]> * Task/WP-520: AppTray should use versionEnabled for list of apps instead of enabled (#991) * Changed enabled.eq.true to versionEnabled.eq.true * Searches for versionEnabled on public apps * Ensured that tests still passed * Added versionEnabled to getPrivateApps * Corrected comments --------- Co-authored-by: Jeff McMillen <[email protected]> Co-authored-by: Jeff McMillen <[email protected]> Co-authored-by: Sal Tijerina <[email protected]> * Bug/WP-24: Disabling Google Drive Integration (#988) * disabling google drive integration and test assertions * Test for No Integrations Available * added test for other 3rd party apps other than google drive * Update client/src/components/DataFiles/DataFilesListing/DataFilesListingCells.jsx Co-authored-by: fnets <[email protected]> * Update client/src/components/DataFiles/fixtures/DataFiles.systems.fixture.js Co-authored-by: fnets <[email protected]> * copy modal filter google drive * Revert changes in opt for settings_custom.py * settings_default drive removal * test revision keep additional 3rd party test * rm vite config push * getByText and custom example revert --------- Co-authored-by: fnets <[email protected]> Co-authored-by: Garrett Edmonds <[email protected]> * Bug/WP-419 Public Data Header Left Margin (#1003) * file fix starting point * header margin styling change * linting * linting * conditional styling on combinedbreadcrumbs * remove breadcrumbs changes * PublicData contentLayoutName pass in to Section * section module readdition * whitespace dif * lint * layout as oneColumn * Task/WP-728: Mutation hook: Copy file (#1000) * initial typescript * saga logic move * url param undefined fix * linting * axios update * mutateAsync changes * onSuccess, onError with async * copyCalls as an array of Promises on return * WP-765: Fix job status button (#1015) * Update CHANGELOG.md for v3.10.0 * Update CHANGELOG.md * Update CHANGELOG.md * WP-778: Fix infinite loop for state update in useEffect (#1019) * WP-778: Fix infinite loop for state update in useEffect * remove unnecessary changes * CSS regression fixes- testing session 2024-11-26 (#1018) Co-authored-by: Chandra Y <[email protected]> * Update CHANGELOG.md for 3.10.1 hotfix * Task/WP-726: Mutation hook: Mkdir (#997) * initial conversion to ts * liniting/formating * dispatch type change * extra dispatch removals * 500 error fix * removed redux test * Task/WP-727: Mutation hook: Upload file (#999) * initial ts convert * for each file and manual headers * removed unused dispatch * axios replacing fetch * mutateAsync --------- Co-authored-by: Jake Rosenberg <[email protected]> * Task/WP-68: Update DataFiles Unit Tests (#992) * WP-68: Initial update of datafiles unit tests * WP-68: Investigation into System Definition and State * showViewPath Coverage * unauth init * attribute error test coverage * put unauth request test * post unauth and handler exception tests * LinkView Exception Tests * post handler exception coverage fix * restore original mocks * linting * Bug/WP-418: site search error when user does not have community file listing access. (#1005) * file fix starting point * ssh_op_err1 exception addition and test * comment fix * linting * Task/WP-729: Mutation hook: Move files (#996) * Converted useMove mutation to use React Query and TypeScript * Linted code to meet quality standards * Removed superfluous comments * Removed unnecessary dispatches to use React Query to properly move files * Linted client code * Edited request to use apiClient, removed console logs * Corrected body of PUT request * Working on test for mutation, still in progress * Update client/src/hooks/datafiles/mutations/useMove.ts Co-authored-by: Sal Tijerina <[email protected]> * Adjusted Dispatch calls * Update client/src/hooks/datafiles/mutations/useMove.ts Adding closing dispatch calls at the end Co-authored-by: Sal Tijerina <[email protected]> * Commenting out useMove.test.ts until React Query move mutation is 100% working * Corrected dispatch calls * Linted client-side code * Removed test file temporarily * Added more asynchronous calls to refine process * Removed extraneous console.log() --------- Co-authored-by: Jeff McMillen <[email protected]> Co-authored-by: Sal Tijerina <[email protected]> Co-authored-by: Chandra Y <[email protected]> * build(deps): bump django from 4.2.16 to 4.2.17 in /server (#1033) Bumps [django](https://github.com/django/django) from 4.2.16 to 4.2.17. - [Commits](django/django@4.2.16...4.2.17) --- updated-dependencies: - dependency-name: django dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bug/WP-779--[Regression] File preview is smaller compared to production (#1032) * ratio bootstrap fix * removed className * Task/WP-505: APCD File Upload Failures Logging Request (#1013) * Adding error messages to upload modal ui * response text for 403 * remove logs and testing code * additional testing reversal * console log removal * 500 errors for testing * try catch for http and network errors * Task/WP-731: Mutation hook: Trash file/folder (#994) * Converted useTrash mutation to use React Query and TypeScript * Linted code to meet quality standards * Removed superfluous comments * Removed extraneous dispatch calls and ran mutations on each selected file * Added more asynchronous calls to further streamline process * Still in the process of getting the trash mutation to work correctly * Trash mutation actually works as intended * Linted client-side code * Reverting changes made to package and package-lock * Refined trash mutation hook to use Axios and Promises * Linted client-side code again * Ensured a Promise is returned --------- Co-authored-by: Jeff McMillen <[email protected]> Co-authored-by: Sal Tijerina <[email protected]> * Updating to address UT security scan. (#1030) * Bug/WP-321: Removing oversized attachments from tickets (#1012) * Added functionality to remove oversized files attached to tickets * Still trying to only delete one oversized file at a time * Still trying to get the list of rejected files to refresh automatically * Finally got to filter rejectedFiles correctly --------- Co-authored-by: Jeff McMillen <[email protected]> * Task/WP-724: Mutation Hooks: Compress Files (#1009) * Starting from scratch * Set up useCompress.ts * Still working on useCompress() * Progressing with useCompress mutation * Committing branch in its current state; not fully functioning * wip * Reworked useCompress.ts * wip * Still trying to fix it; much closer now * handle undefined execSystemId * Compress mutation finally successful * Toasts and modals work correctly * Linted client-side code * Added an additional asynchronous call; updated Compress modal * Refactored types into useSubmitJob.ts * Corrected mutation hook to return archive in current directory instead of root * Update client/src/hooks/datafiles/mutations/useCompress.ts Co-authored-by: Sal Tijerina <[email protected]> * Linted client-side code * Can't get this test to pass still * Linted client-side code * Finally got the failing test to pass * Skipping tests temporarily, cleaned up code * Skipping saga tests * Corrected defaultPrivateSystem and edited package-lock.json * Made corrections to files based on feedback * Added final change to account for empty strings or undefined in job_post['appVersion'] * Task/WP-725: Mutation Hooks: Extract Files (#1035) * Set up new branch to branch off of Compress branch * Reversed changes to files based on feedback after rebasing branch * Skipping failing test temporarily * Linted client-side code * Removed changes to files unrelated to task due to pointing a branch to a branch other than main --------- Co-authored-by: Jeff McMillen <[email protected]> * update example; add comment --------- Co-authored-by: Jeff McMillen <[email protected]> Co-authored-by: Sal Tijerina <[email protected]> * Bug/WP-364: Ticket creation emails are not sent to 'cc' emails (#1017) * Edited modal to warn users about CC email limitations * Reversed changes made based on feedback * Corrected all incorrect uses of Requestor vs Requestors * poetry setting package mode to false to solve install issue --------- Co-authored-by: Jeff McMillen <[email protected]> Co-authored-by: Chandra Y <[email protected]> * Bug/WP-782: Resized View Full Path link in modals (#1036) * Resized View Full Path link in modals * Linted code * Correctly sized the View Full Path as-link button in modals * Linted code * fix: misspelling * fix: my bad math * fix: combinedbreadcumbs css mis-compiles global class --------- Co-authored-by: Jeff McMillen <[email protected]> Co-authored-by: Wesley B <[email protected]> Co-authored-by: Chandra Y <[email protected]> * refactor: wp-791 dropdown menu (#1028) * refactor: WP-791 dropdown button menu - remove most of the redundant code - use Dropdown not ButtonDropdown - fix layout of menu and button in DataFilesSidebar - clean up our .dropdown-menu styles - use variables for arrow and border * refactor: WP-791 DataFilesBread… dropdown menu `….scss`: - use class not ID - position via `top` not `margin-top` - explain menu position's "magic" value - explain why positioning is necessary[^1] `….jsx`: - use class not ID use Dropdown not ButtonDropdown[^2] [^1]: Not desired, but necessary if we use our custom <Button> as is. [^2]: I don't see ButtonDropdown in latest ReactStrap (v9). * chore: remove class data-files-btn This class is assigned to buttons that: - **either** have Bootstrap btn-primary (in which case the `.workbench-content .btn-primary` styles it) - **or** are our custom `<Button>` (in which case the `composes: c-button` styles it) * doc: save `refactor/WP-791-dropdown-menu` PR desc * Revert "chore: remove class data-files-btn" This reverts commit 1b644ed. * style: npm run prettier:fix * chore: remove unnecessary `!important` * enhance: use `<DropdownItem divider>` consistently * chore: refactor-WP-791-dropdown-menu-pr-desc.md --------- Co-authored-by: Chandra Y <[email protected]> * chore: remove class data-files-btn (#1029) * chore: remove class data-files-btn This class is assigned to buttons that: - **either** have Bootstrap btn-primary (in which case the `.workbench-content .btn-primary` styles it) - **or** are our custom `<Button>` (in which case the `composes: c-button` styles it) * doc: save `chore/remove-data-files-btn` PR desc * chore: delete chore-remove-data-files-btn-pr-desc.md * chore: delete chore-remove-data-files-btn-pr-desc.md * style: npm run prettier:fix * WP-781: FIx UI formatting issues (#1038) * WP-774: FIx UI formatting issues * linting * build(deps-dev): bump vite from 5.4.8 to 5.4.14 in /client (#1039) Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.4.8 to 5.4.14. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v5.4.14/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.4.14/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Chandra Y <[email protected]> * build(deps): bump django from 4.2.17 to 4.2.18 in /server (#1040) Bumps [django](https://github.com/django/django) from 4.2.17 to 4.2.18. - [Commits](django/django@4.2.17...4.2.18) --- updated-dependencies: - dependency-name: django dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Chandra Y <[email protected]> * task/wp-833: resource json update to include vista (#1042) * resource json update * update settings * WP-835: Click through file location in site search results is failing (#1045) * WP-835: Fix site search and data files usage of compress and extract * handle no allocation scenario * Add explicit CORS config to Vite (#1048) * task/WP-682: Fix Community Project Folders on Core portals (#1041) * To update ACLs on shared systems outside of the root project's directory (community data), the target of updating ACLs needs to be the system itself rather than the parent root system. * In the case where a user is added to a project but doesn’t have file permissions assigned, this function would fail which blocks the portal from getting the project at all. * Resolving issues with root directory hardcoding and refactoring function to use the system terminology instead of project terminology * minor refactoring * Changed ACL job to submit with the user's client, so that we know the system will have the credentials needed for the job. Truncated the job name to fit with Tapis JSON requirements. And changed the client used to add a user to a shared system so that we know the system will have the credentials needed to make the change. * Adding path back into logger statement. * Fixed unit tests to work with code changes. * Fixed linting errors * Minor cleanup, setting the set_facl_job to run by default * chore: do not clone bootstrap for tacc-search-bar (#971) Co-authored-by: Chandra Y <[email protected]> * Task/WP-832: switching to TMS for credentials (#1051) * switching to tms for credentials * lint fix * Address review comments * Update server/portal/apps/workspace/api/utils.py Co-authored-by: fnets <[email protected]> * Client adjustments for Keys * linting and onboarding adjustment * Update to latest tapipy * fixing poetry error * Fix testing credentials --------- Co-authored-by: fnets <[email protected]> * fix upload with empty path (#1055) * build(deps-dev): bump vitest and @vitest/coverage-v8 in /client (#1053) Bumps [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) and [@vitest/coverage-v8](https://github.com/vitest-dev/vitest/tree/HEAD/packages/coverage-v8). These dependencies needed to be updated together. Updates `vitest` from 2.1.2 to 2.1.9 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Commits](https://github.com/vitest-dev/vitest/commits/v2.1.9/packages/vitest) Updates `@vitest/coverage-v8` from 2.1.2 to 2.1.9 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Commits](https://github.com/vitest-dev/vitest/commits/v2.1.9/packages/coverage-v8) --- updated-dependencies: - dependency-name: vitest dependency-type: direct:development - dependency-name: "@vitest/coverage-v8" dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Chandra Y <[email protected]> * build(deps): bump cryptography from 43.0.1 to 44.0.1 in /server (#1054) Bumps [cryptography](https://github.com/pyca/cryptography) from 43.0.1 to 44.0.1. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@43.0.1...44.0.1) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Chandra Y <[email protected]> * task/WI-239: Add audit logs for datafiles/projects endpoints (#1047) * add audit logs for datafiles/projects endpoints * unit test fixes * linting fixes * more linting fixes * unit test fixes * pass tracking id to shared workspace mkdir * WI-240: auth, apps, jobs audit logs (#1052) * auth, apps, jobs audit logs * fix test * fix test * fix tests * fix tests --------- Co-authored-by: Sal Tijerina <[email protected]> * build(deps): bump dompurify from 2.5.7 to 3.2.4 in /client (#1058) Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.5.7 to 3.2.4. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@2.5.7...3.2.4) --- updated-dependencies: - dependency-name: dompurify dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Chandra Y <[email protected]> * update react-query usage * task/WP-834 - Add behavior for ignoring DesignSafe-Corral allocation for running jobs (#1057) * Added changes to remove TAS projects that are purely administrative from default allocations, as they were preventing a few users from running jobs. * Update server/portal/apps/users/views.py --------- Co-authored-by: Chandra Y <[email protected]> Co-authored-by: Garrett Edmonds <[email protected]> * WP-865 - sending file to trash in shared workspaces (#1049) Co-authored-by: Garrett Edmonds <[email protected]> * increase axios timeout (#1062) Co-authored-by: Chandra Y <[email protected]> * Update CHANGELOG.md * WP-878: Shared workspaces upload to root folder is failing (#1065) * WP-878: upload to root fix * fix unit test * Revert TMS change (#1069) * Revert TMS change This reverts commit f4b5b90, reversing changes made to a2ba0dc. * fix: WP-895 portal nav position wrong on portal (#1071) but works fine on cms * Fix: Workbench drop down menu is cut off on the right. (#1066) * Fix: Workbench drop down is cut off on the right. * Revert custom CSS Update Dropdown menu class --------- Co-authored-by: Chandra Y <[email protected]> * update to fix upload and trash functionality * updates to data display and fixed metrics logging bug * update TreeView MUI package * update MUI package for TreeView * update package-lock.json --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Jeff McMillen <[email protected]> Co-authored-by: Jeff McMillen <[email protected]> Co-authored-by: Jacob Lowe <[email protected]> Co-authored-by: Chandra Y <[email protected]> Co-authored-by: Sal Tijerina <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jake Rosenberg <[email protected]> Co-authored-by: Garrett Edmonds <[email protected]> Co-authored-by: fnets <[email protected]> Co-authored-by: Jeff McMillen <[email protected]> Co-authored-by: Garrett Edmonds <[email protected]> Co-authored-by: Jeff McMillen <[email protected]> Co-authored-by: Wesley B <[email protected]> Co-authored-by: Juan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix position of menu of portal nav on Portal. (It is positioned as expected on CMS.)
Related
Changes
Testing
UI
wp-895.portal.-.480p.mov
Notes
Important
Other dropdown menu positions work because they rely on Reactstrap for JavaScript.1
Tip
The bug of orange underline appearing beneath header is fixed separately in #1068.
Footnotes
Wait, so… the HTML-driven load of Bootstrap JavaScript is only for the portal nav dropdown? Maybe. Well, shouldn't that be investigated and, if so, streamlined? Yes, but out of scope of this task, which is already an offshoot of another task, which is already a two-day distraction from my urgent tasks. ↩