Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support disabling elasticsearch #834

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jun 11, 2024

Overview

Allow a project to disable ElasticSearch.

Related

Changes

  • added setting PORTAL_ES_ENABLED
  • moved search settings to _settings/search.py
  • changed search settings to require PORTAL_ES_ENABLED

Testing

  1. Create new CMS-only Portal.
  2. Deploy.
  3. Create homepage.
  4. Verify homepage is created (no 500 error).

UI

Ref. Link
Image taccwma/core-cms/feat-support-disabling-elasticsearch
Deploy Core_Portal_Deploy#405
Website https://pprd.wtcs.tacc.utexas.edu/ (has a homepage)

@wesleyboar wesleyboar marked this pull request as ready for review June 11, 2024 23:08
Copy link
Collaborator

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as advertised for me.

@wesleyboar wesleyboar merged commit 5aacb33 into main Jun 25, 2024
@wesleyboar wesleyboar deleted the feat/support-disabling-elasticsearch branch June 25, 2024 22:18
wesleyboar added a commit that referenced this pull request Aug 7, 2024
I.e. Fix v4.11.1's #834 being ineffectual.
wesleyboar added a commit that referenced this pull request Aug 8, 2024
* fix: CMD-176 unable to disable elastic search

I.e. Fix v4.11.1's #834 being ineffectual.

* refactor: CMD-176 rename search to es_search

* fix: CMD-176 always install aldryn_apphooks_config

* style: simpler variable name

* fix: install search plugins where they had been

* chore: delete testing cruft

* chore: delete duplicate settings

* fix: do not override secrets

* fix: restore default ES_* secrets

* refactor: …_ES_ENABLED→…_SEARCH_INDEX_IS_AUTOMATIC

* docs: …_ES_ENABLED → …_SEARCH_INDEX_IS_AUTOMATIC

* fix: settings_custom.example.py
wesleyboar added a commit that referenced this pull request Aug 8, 2024
* fix: CMD-176 unable to disable elastic search

I.e. Fix v4.11.1's #834 being ineffectual.

* refactor: CMD-176 rename search to es_search

* fix: CMD-176 always install aldryn_apphooks_config

* style: simpler variable name

* fix: install search plugins where they had been

* chore: delete testing cruft

* chore: delete duplicate settings

* fix: do not override secrets

* fix: restore default ES_* secrets

* refactor: …_ES_ENABLED→…_SEARCH_INDEX_IS_AUTOMATIC

* docs: …_ES_ENABLED → …_SEARCH_INDEX_IS_AUTOMATIC

* fix: settings_custom.example.py

* fix: settings_cusotm BRANDING out of date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants