Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/fp 1378 consistent space above footer #480

Merged
merged 10 commits into from
May 4, 2022

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Apr 25, 2022

Overview

Use consistent space between main content and footer.

Related

Changes

Testing

Core

  1. Verify 45px of space is between main content and footer on several pages, e.g.
  2. Verify that a page with very little content but a tall window still pins footer to bottom of page.

Texascale

⚠️ Unable to test Texascale because it is not deployed with Camino and is too out-of-date to manually update. But its change (TACC/Core-CMS-Resources#134) is simple and Texascale will be migrated to Camino in CEPWMA-679 and Texascale 2022 development this summer will test it.

Screenshots

Test Step 1

User View Dev View
Default Portal Homepage Portal Home - User View Portal Home - Dev View
Random Guide Page Guide Page - User View Guide Page - Dev View
Typography Style Guide Typography - User View Typography - Dev View

Test Step 2

Footer is pinned to bottom on tall window. (click to show image)

Short Page Tall Window

@wesleyboar wesleyboar marked this pull request as ready for review May 3, 2022 22:54
package.json Outdated
@@ -9,7 +9,7 @@
"npm": "8.5.5"
},
"devDependencies": {
"@tacc/core-styles": "git+https://[email protected]/TACC/Core-Styles.git",
"@tacc/core-styles": "git+https://[email protected]/TACC/Core-Styles.git#task/FP-1378-consistent-space-above-footer",
Copy link
Member Author

@wesleyboar wesleyboar May 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not intended to be merged. After PR approval, I plan to revert this change (and rebuild package-lock.json) so the latest Core-Styles is loaded.

That branch is transient (deleted after merge of the related PR), so merging this change to main would soon result in npm install fail. What I should do, is pin to a specific version… but I am currently loading latest of Core-Styles, to facilitate rapid development. Core-Styles is versioned (releases), but I don't really have a process for Core-Styles, yet. How do I version what hasn't been merged?

@wesleyboar
Copy link
Member Author

wesleyboar commented May 4, 2022

@duckonomy Dev Core CMS has been re-built and deployed. Now it shows this branch again.

@duckonomy duckonomy self-requested a review May 4, 2022 17:43
Copy link
Contributor

@duckonomy duckonomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wesleyboar wesleyboar merged commit ee365e8 into main May 4, 2022
@wesleyboar wesleyboar deleted the task/FP-1378-consistent-space-above-footer branch May 4, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants