-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/fp 1378 consistent space above footer #480
Conversation
package.json
Outdated
@@ -9,7 +9,7 @@ | |||
"npm": "8.5.5" | |||
}, | |||
"devDependencies": { | |||
"@tacc/core-styles": "git+https://[email protected]/TACC/Core-Styles.git", | |||
"@tacc/core-styles": "git+https://[email protected]/TACC/Core-Styles.git#task/FP-1378-consistent-space-above-footer", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is not intended to be merged. After PR approval, I plan to revert this change (and rebuild package-lock.json
) so the latest Core-Styles is loaded.
That branch is transient (deleted after merge of the related PR), so merging this change to main
would soon result in npm install
fail. What I should do, is pin to a specific version… but I am currently loading latest of Core-Styles, to facilitate rapid development. Core-Styles is versioned (releases), but I don't really have a process for Core-Styles, yet. How do I version what hasn't been merged?
@duckonomy Dev Core CMS has been re-built and deployed. Now it shows this branch again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Overview
Use consistent space between main content and footer.
Related
Changes
--global-space--section-gap
from https://github.com/TACC/Core-Stylestexascale-org
to use the new variableTesting
Core
Texascale
Screenshots
Test Step 1
Test Step 2
Footer is pinned to bottom on tall window. (click to show image)