Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FP-1410: Shrink Guide Images & Add Links to Open in New Tab #462

Merged
merged 2 commits into from
Mar 11, 2022

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Mar 10, 2022

Overview

  • Shrink […] Data Transfer guide images consistently on wide screens.
  • Link images so they open in new tab. (Add bug fix for it.)

Related

  • fixes: FP-1410
  • created after work began: FP-1542 (to replace the URLs with ones to locally-available images)

Changes

  • delete redundant code
  • add <a>'s
  • set absolute max-width for images, but otherwise (i.e. mobile) let images grow to fill screen
  • shrink one image a little extra
  • prevent new bug of really large invisible link

Testing

  1. Load these pages1:
  2. Scroll to see all images while on wide screen.
  3. Scroll to see all images while on narrow screen.
  4. No image should be excessively large nor small.2
  5. Each image should link to full-size.
  6. Report any seemingly related UI bugs.

Screenshots

Data Transfer Guide

576px
AFTER BEFORE
Data Transfer 576px AFTER Data Transfer 576px BEFORE
992px
AFTER BEFORE
Data Transfer 992px AFTER Data Transfer 992px BEFORE
1680px
AFTER BEFORE
Data Transfer 1680px AFTER Data Transfer 1680px BEFORE

Globus Data Transfer Guide

576px
AFTER BEFORE
Globus Data 576px AFTER Globus Data 576px BEFORE
992px
AFTER BEFORE
Globus Data 992px AFTER Globus Data 992px BEFORE
1680px
AFTER BEFORE
Globus Data 1680px AFTER Globus Data 1680px BEFORE

Footnotes

  1. If testing locally, you'll need to create those two pages. To put content on them, choose the correct page template, which are best to define in the settings_custom.py. Example: ('guides/data_transfer.globus.html', 'Guide: Globus Data Transfer').

  2. At some widths (992px or 576px depending on the page), images are larger than before. That's okay—they were too small on mobile for narrow screens, and Design likes images on mobile to take up all of page width (unless its some intentionally small image). What I did was pick a max size for these guides' images that offered legibility without being too large. At a much wider width, the images are definitely smaller than before.

@wesleyboar wesleyboar marked this pull request as ready for review March 10, 2022 22:36
Copy link
Member Author

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments for reviewers.

@wesleyboar wesleyboar force-pushed the task/FP-1410-images-too-large-in-transfer-guides branch from 25d8824 to 49ac733 Compare March 10, 2022 23:04
Copy link
Contributor

@edmondsgarrett edmondsgarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Images are appropriate size for wide & narrow windows, and behave as otherwise described in testing steps.

@wesleyboar wesleyboar merged commit ba0b716 into main Mar 11, 2022
@wesleyboar wesleyboar deleted the task/FP-1410-images-too-large-in-transfer-guides branch March 11, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants