Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/FP-1289 Image Grid Pattern #415

Merged
merged 38 commits into from
Dec 9, 2021
Merged

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Dec 1, 2021

Overview

Create class for CMS editors to use to create image grids (but not galleries).

Issue

FP-1289

Changes

  • New o-grid CSS class (and sample markup).
  • New snippet (symlink to CSS sample markup).
  • New global variable for grid gap (match Bootstrap value).
  • New x-grid CSS mixin.

Demos

Demo Notes
Core CMS Dev Pattern Library supports .o-grid via Core
Automated Pattern Library test of ugly KSS software
Core CMS Live Pattern Library supports .o-grid via snippet

Screenshots

All Snippets Example Gallery
FP-1289 Four Snippets FP-1289 Example - Center, Auto

Testing

Remote:

Jenkins Jobs
  1. Open https://dev.cep.tacc.utexas.edu/design-system/pattern-library/o-grid/.
  2. If this branch is deployed, then the page should load many sets of collapsed galleries.
  3. Follow "Remote & Local" steps.

Local:

Snippets to Make

NAME: UI: O-Grid: fill, auto
HTML: o-grid--image-fill o-grid--col-auto-count
TEMPLATE: snippets/manual-pattern-library/o-grid.html

NAME: UI: O-Grid: center, auto
HTML: o-grid--center-align o-grid--col-auto-count
TEMPLATE: snippets/manual-pattern-library/o-grid.html

NAME: UI: O-Grid: fill, auto
HTML: o-grid--image-fill o-grid--col-auto-count
TEMPLATE: snippets/manual-pattern-library/o-grid.html

NAME: UI: O-Grid: fill, min
HTML: o-grid--center-align o-grid--col-min-width
TEMPLATE: snippets/manual-pattern-library/o-grid.html

  1. Be familiar with how to Test CMS Changes.
  2. Create snippets that uses template snippets/manual-pattern-library/o-grid.html.
  3. Follow "Remote & Local" steps.

Remote & Local:

  1. Expand each gallery within each section/snippet.
  2. Confirm that each class combination1 does what each class says it should.
    • To test each class individually, you can reduce the classnames passed in the HTML snippets.2
    • To test number of columns, resize window. For o-grid--col-auto-count, test standard breakpoints.

Footnotes

  1. Most uses of o-grid will likely have two of these modifier classes.

  2. To preview this, see tacc-wbomar-css-pattern-library-kss.surge.sh.

@wesleyboar wesleyboar marked this pull request as draft December 1, 2021 23:03
@wesleyboar wesleyboar changed the title Task/FP-1289 Image Grid Gallery Task/FP-1289 Image Grid Pattern Dec 1, 2021
@wesleyboar wesleyboar force-pushed the task/FP-1289-image-grid-gallery branch from 56976b5 to c1c92b1 Compare December 4, 2021 02:21
Copy link
Member Author

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added notes for reviewers.

@wesleyboar wesleyboar marked this pull request as ready for review December 6, 2021 20:17
Copy link
Contributor

@duckonomy duckonomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to follow the testing steps locally with snippets and through the deployed branch!
LGTM!
Thanks for redeploying by the way!

@wesleyboar wesleyboar merged commit 5e7b680 into main Dec 9, 2021
@wesleyboar wesleyboar deleted the task/FP-1289-image-grid-gallery branch December 9, 2021 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants