-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/FP-1289 Image Grid Pattern #415
Conversation
56976b5
to
c1c92b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added notes for reviewers.
taccsite_cms/templates/snippets/manual-pattern-library/README.md
Outdated
Show resolved
Hide resolved
taccsite_cms/templates/snippets/manual-pattern-library/o-grid.content.html
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was able to follow the testing steps locally with snippets and through the deployed branch!
LGTM!
Thanks for redeploying by the way!
Overview
Create class for CMS editors to use to create image grids (but not galleries).
Issue
FP-1289
Changes
o-grid
CSS class (and sample markup).x-grid
CSS mixin.Demos
.o-grid
via Core.o-grid
via snippetScreenshots
Testing
Remote:
Jenkins Jobs
Local:
Snippets to Make
snippets/manual-pattern-library/o-grid.html
.Remote & Local:
o-grid--col-auto-count
, test standard breakpoints.Footnotes
Most uses of
o-grid
will likely have two of these modifier classes. ↩To preview this, see tacc-wbomar-css-pattern-library-kss.surge.sh. ↩