Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/FP-1338: Offset Content to be Full Width on Narrow Window #406

Merged
merged 2 commits into from
Nov 11, 2021

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Nov 11, 2021

Requires

Overview

Ensure "offset content" elements are full width on narrow windows.

Issues

FP-1338

Screenshots

Narrow Window Wide Window
Narrow Window Wide Window

Testing

  1. Open https://texascale-dev.tacc.utexas.edu/2020/feature-stories/twisted-physics/.
  2. On wide window, find offset content (content offset from flow of article text).
  3. Ensure offset content:
    • does not span 100% of container
    • is offset
    • text wraps around one end of it
  4. On narrow window, find the content that was offset (it should now be in flow with article text).
  5. Ensure content that was offset
    • does span 100% of container
    • not offset
    • text does not wraps around one end of it

Notes

The o-offset-content (new, Core) and c-offset-content (deprecated, Texascale) are both maintained (and now fixed).

Copy link
Member Author

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes for reviewers.

@wesleyboar
Copy link
Member Author

Merging. Stakeholder (H.P.) has tested and approved the result. The code is long-standing simple bug fixes. The drive is Texascale 2021 launch.

@wesleyboar wesleyboar merged commit c23eb3f into main Nov 11, 2021
@wesleyboar wesleyboar deleted the hotfix/FP-1338-offset-content-width-on-narrow-screen branch November 11, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant