Hotfix/FP-1333: Callout Title Color #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, note that a s-section should be created via FP-1318.
wesleyboar
commented
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Ensure callout title is always white, even inside a section which tries to color headings.
Issues
FP-1333
Testing
o-section--style-lightclass of the ancestor<section>too-section--style-dark.Notes
In FP-1318, I will move this and related styles to a new trump file
s-section.css.Why?
Because a "scope" (
s-) trump is more appropriate for cross-layer styles (e.g.…-sectionand.c-callout,…-sectionand any element/tag).Footnotes
Deployed via https://jenkins01.tacc.utexas.edu/job/Core_Portal_Deploy/851/ which loads image from branch
main--v3-3-0-with-hotfixes. ↩