Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/FP-1331: Do Not Hide Header Drodpowns #404

Merged
merged 4 commits into from
Nov 12, 2021

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Nov 11, 2021

Overview

Do not hide header dropdown menus underneath body content.

Issues

FP-1331

Testing

  1. Load these pages to test:
  2. Be logged into portal.
    1. Login to Portal.
    2. Return to CMS.
  3. Open Portal dropdown menu.
  4. Verify dropdown menu can be seen (test both pages).

Notes

This removed code had solved a problem that has since been solved by other code.

Footnotes

  1. Deployed via https://jenkins01.tacc.utexas.edu/job/Core_Portal_Deploy/849/ which loads image from branch main--v3-3-0-with-hotfixes. 2

@wesleyboar wesleyboar marked this pull request as ready for review November 11, 2021 22:03
Copy link
Contributor

@edmondsgarrett edmondsgarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works as described.

Copy link
Collaborator

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wesleyboar
Copy link
Member Author

Thanks y'all.

@wesleyboar wesleyboar merged commit a6dcab4 into main Nov 12, 2021
@wesleyboar wesleyboar deleted the hotfix/FP-1331-do-not-hide-header-dropdowns branch November 12, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants