-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UTRC-357/FP-1268: Retire v1 Styles (Use v2 Styles) #360
Merged
wesleyboar
merged 11 commits into
main
from
task/UTRC-357-retire-v1-styles-use-v2-styles
Dec 13, 2021
Merged
UTRC-357/FP-1268: Retire v1 Styles (Use v2 Styles) #360
wesleyboar
merged 11 commits into
main
from
task/UTRC-357-retire-v1-styles-use-v2-styles
Dec 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ements of the following: commit 420821d Author: Wesley Bomar <[email protected]> Date: Thu Sep 23 02:01:14 2021 -0500 GH-353: Use Var for Bold (on Last Commit) commit 83c5c5d Author: Wesley Bomar <[email protected]> Date: Thu Sep 23 01:56:01 2021 -0500 GH-353: Fix Missing Bold for Guide Pages
Also, add Standard Homepage and Guides templates to example settings.
wesleyboar
changed the title
Squashed merge of bugfix/GH-353-fix-missing-bold-for-guide-page-dt-elements of the following:
UTRC-357: Retire v1 Styles (Use v2 Styles)
Sep 27, 2021
This was referenced Sep 27, 2021
taoteg
approved these changes
Sep 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pending test on UTRC, to be sure. |
wesleyboar
changed the title
UTRC-357: Retire v1 Styles (Use v2 Styles)
UTRC-357/FP-1268: Retire v1 Styles (Use v2 Styles)
Oct 8, 2021
I have tested successfully with pure remote build. (Previous testing was inference-based.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Do
Done
Requires
This ensures v2 styles work well on
<h1>
(missing margin is too obvious on these heavily-used elements).All the actual code changes for UTRC-357 are in this PR.
Overview
(Update submodule pointer to commit.) Remove v1-v2 migration styles from UTRC.
Issues
Testing
Refer to "Testing" of each PR in "Requires".