GH-101: Portal Nav Mobile - Link Style #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Limit large nav link padding to CMS links. - Limit nav icon spacing depending on nav and screen width. - Split icon styles between compressed and expanded. - Add missing markup for `s-portal-nav` sample HTML.
- New CSS plugin test for nested @extend's. - New mixin "mobile button". - Use mixin for mobile button styles in header.
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Make portal nav icon, text, and dropdown match design.¹
¹ See "Known Issues" 1.
Issues
Changes
s-portal-navsample HTML.Testing
and when logged out, match design.¹²¹ See "Known Issues" 1.
² Can not test logged out Portal Nav on Portal.
Notes
Known Issues
Text of Portal nav is capitalized in dev, but not design.
In an upcoming PR, the portal nav will be moved to the right of the navbar toggler. This layout suggests that the casing should be the same. If the casing should be different, it can be brought up as a bug in GH-101/FP-1458: Header Redesign #222. But right now, I am avoiding possibly superfluous deviation of style, because the code is already unwieldy.