Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick: Deprecate site_shared #218

Merged
merged 1 commit into from
May 10, 2021
Merged

Quick: Deprecate site_shared #218

merged 1 commit into from
May 10, 2021

Conversation

wesleyboar
Copy link
Member

Overview

  • Remove folder that was added in premature attempt to share Portal and CMS CSS.
  • Update relevant paths and documentation.

Changes

  • Remove taccsite_cms/static/site_shared.
  • Update @import paths that import from taccsite_cms/static/site_shared.
  • Fix documentation to not reference the deleted directory.

Testing

Follow steps at Test Build Output (in wiki) using frontera-cms as project.

@wesleyboar
Quick: Deprecate site_shared
e4ed6d7 
This folder was added in premature attempt to share Portal and CMS CSS.
@wesleyboar wesleyboar mentioned this pull request May 10, 2021
Merged
@wesleyboar wesleyboar marked this pull request as ready for review May 10, 2021 22:32
@wesleyboar
Copy link
Member Author

Tested. Zero difference in built files from main and quick/deprecate-site_shared. Merging.

@wesleyboar wesleyboar merged commit 9353538 into main May 10, 2021
@wesleyboar wesleyboar deleted the quick/deprecate-site_shared branch May 10, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar