Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/gh 171 support css that is forwards compatible #173

Merged
merged 5 commits into from
Apr 9, 2021
Merged

Task/gh 171 support css that is forwards compatible #173

merged 5 commits into from
Apr 9, 2021

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Mar 30, 2021 •
edited
Loading

Overview

  1. Add plugin postcss-preset-env to support forward-compatible CSS.
  2. Support urgent-need features:
  3. Do not remove duplicate CSS i.e. do not sweep bad CSS under the rug.

Related Issues

Testing

  1. Run npm ci to clean install node dep's.
  2. Run npm run build to build CSS, including a plugin test file.
  3. Open taccsite_cms/static/site_cms/css/build/_test.css.
  4. Ensure output matches what the files reports the output should be.

@wesleyboar wesleyboar requested a review from taoteg March 30, 2021 04:04
This was referenced Mar 30, 2021
Closed
Closed
@wesleyboar wesleyboar linked an issue Mar 30, 2021 that may be closed by this pull request
Support Forward-Compatible CSS #171
Closed
@wesleyboar wesleyboar removed the request for review from taoteg April 2, 2021 10:17
@wesleyboar wesleyboar added the priority ━ Medium priority label Apr 6, 2021
wesleyboar
wesleyboar commented Apr 8, 2021
View reviewed changes
Copy link
Member Author

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes

conf/css/postcss.config.js Show resolved Hide resolved
conf/css/postcss.config.js Show resolved Hide resolved
taccsite_cms/static/site_cms/css/src/_imports/_tests/postcss-preset-env.css Show resolved Hide resolved
taoteg
taoteg approved these changes Apr 9, 2021
View reviewed changes
Copy link
Collaborator

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@wesleyboar wesleyboar merged commit 7d4ee06 into main Apr 9, 2021
@wesleyboar wesleyboar deleted the task/GH-171-support-css-that-is-forwards-compatible branch April 9, 2021 21:45
This was referenced Apr 10, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taoteg taoteg taoteg approved these changes

Assignees
No one assigned
Labels
priority ━ Medium priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Forward-Compatible CSS
2 participants
@wesleyboar @taoteg