Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-149: Polish base.html markup #151

Merged
merged 16 commits into from
Apr 24, 2022
Merged

GH-149: Polish base.html markup #151

merged 16 commits into from
Apr 24, 2022

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Mar 3, 2021 •
edited
Loading

Overview

Improve the markup of base.html.

These changes have been pending since 2019, and sitting in a branch (since deleted in favor of this branch) for 2020+, but have been too cumbersome for which to create and test a PR (and too minor a change) until now.

Related

Changes

  1. Remove unnecessary ID attribute.
  2. Update markup to be semantic.
  3. Remove unnecessary <div> wrap.
  4. Remove two superfluous comments.
  5. Load Core-CMS-Resources and Core-Styles cleanup that depend on this.

Screenshots

Localhost (Markup) Texascale (Layout)1
GH-149 GH-149 Texascale

Testing

  1. Check that markup is correctly nested.
  2. Check that pulling footer out of #cms-content has no effect on layout.

Footnotes

  1. Manually manipulated markup to test. ↩

@wesleyboar
GH-149: Polish base.html markup
d1db1ee 
1. Remove unnecessary ID attribute.
2. Update markup to be semantic.
3. Remove unnecessary `<div>` wrap.
@wesleyboar wesleyboar added the priority ▼ Low priority label Mar 3, 2021
@wesleyboar wesleyboar added blocked Unable to continue work enhancement Improvements or additions to existing features labels Mar 15, 2021
@wesleyboar wesleyboar linked an issue Apr 6, 2021 that may be closed by this pull request
Polish base.html Markup #149
Closed
@wesleyboar wesleyboar removed blocked Unable to continue work enhancement Improvements or additions to existing features labels Jul 3, 2021
@wesleyboar wesleyboar marked this pull request as draft July 6, 2021 21:37
@wesleyboar wesleyboar added the paused Started but not actively in progress label Jul 30, 2021
@wesleyboar
Copy link
Member Author

When I un-pause this PR, I will re-open it.

@wesleyboar wesleyboar closed this Jul 30, 2021
@wesleyboar
Copy link
Member Author

I almost lost this PR, so I am opening back up, but as a draft.

@wesleyboar wesleyboar reopened this Nov 4, 2021
@wesleyboar wesleyboar added priority ▼▼ Very low priority and removed priority ▼ Low priority labels Nov 4, 2021
@wesleyboar wesleyboar removed the priority ▼▼ Very low priority label Mar 22, 2022
@wesleyboar wesleyboar mentioned this pull request Apr 24, 2022
Merged
@wesleyboar wesleyboar marked this pull request as ready for review April 24, 2022 20:58
@wesleyboar wesleyboar mentioned this pull request Apr 24, 2022
Merged
@wesleyboar wesleyboar merged commit 7fc6738 into main Apr 24, 2022
@wesleyboar wesleyboar deleted the task/GH-149-polish-base-html-markup branch April 24, 2022 21:06
@wesleyboar wesleyboar removed the paused Started but not actively in progress label May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Polish base.html Markup
1 participant
@wesleyboar