Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No Project-Specific Header Styles #223

Closed
wesleyboar opened this issue May 17, 2021 · 1 comment
Closed

No Project-Specific Header Styles #223

wesleyboar opened this issue May 17, 2021 · 1 comment
Labels
bug Something isn't working effort M Medium effort task (~1 week) — does not include review time priority ━ Medium priority

Comments

@wesleyboar
Copy link
Member

wesleyboar commented May 17, 2021 •
edited
Loading

Project-specific styles can exist since TACC/Core-Portal#799.

Overview

Project-specific header stylesheet is not loaded on Portal, so project-specific header styles are not applied on Portal.

Results

  1. Header Search Bar Font Size Differs Among Subsites #230. On Frontera, CMS (and User Guide) search bar text is small, but Portal search bar text is large. (Whereas on Core, Portal and CMS search bar text is large, because there are no project-specific header styles.)

  2. On Core-CMS and Core-CMS-Resources branches task/GH-101-header-redesign--navigation-bar, CMS (and User Guide) image width is 190px, but Portal image width is auto.

Prerequisites

  1. Have a frontera-cms project with a connected Portal.¹
  2. Have a CMS page that loads a Frontera template (ex: fullwidth.html, home.html).
  3. Be logged into Portal.

¹ To test on existing portal, see pprd.frontera-portal. To set up local instance, see wiki: Test CMS Changes or wiki: Locally Develop CMS & Portal….

Steps

  1. Load CMS page.
  2. Confirm that file /static/frontera-cms/css/build/site.header.css is loaded by header.
  3. Load Portal page.

Expected Result

  • File /static/frontera-cms/css/build/site.header.css is loaded by header.

Actual Result

  • File /static/frontera-cms/css/build/site.header.css is not loaded anywhere.
@wesleyboar wesleyboar added bug Something isn't working priority ━ Medium priority effort M Medium effort task (~1 week) — does not include review time labels May 17, 2021
wesleyboar added a commit that referenced this issue May 17, 2021
@wesleyboar
GH-101: Navigation Bar (Logo Width, CMS Nav Align)
538369a 
- Add frontera-cms logo width overwrite (temp. ineffectual, see GH-223).
- Prevent Core (but not a project) from stretching logo too wide.
- Align CMS nav for narrow logos. Allow project-specific adaptation.
@wesleyboar wesleyboar changed the title No Project-Specific Header Styles / Frontera Portal Search Bar Font Size Wrong No Project-Specific Header Styles May 25, 2021
This was referenced May 25, 2021
Closed
Merged
@wesleyboar
Copy link
Member Author

Project-specific styles can exist since TACC/Core-Portal#799.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working effort M Medium effort task (~1 week) — does not include review time priority ━ Medium priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wesleyboar