Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do Not Support CMS Menu Dropdown Nav Link #129

Closed
wesleyboar opened this issue Feb 8, 2021 · 1 comment · Fixed by #225 · May be fixed by #222
Closed

Do Not Support CMS Menu Dropdown Nav Link #129

wesleyboar opened this issue Feb 8, 2021 · 1 comment · Fixed by #225 · May be fixed by #222
Assignees
Labels
bug Something isn't working effort XS Extra small effort task (~¼ a week) — does not include review time paused Started but not actively in progress priority ▲ High priority

Comments

@wesleyboar
Copy link
Member

wesleyboar commented Feb 8, 2021

Status

Moved to FP-1235.

Archived

Original description...

Status

  1. [Intended to] be done via Header Redesign → FP-1458 #101[, but that ticket is taking too long.]
  2. Performed via b2cec49 (but not in isolation, see taccsite_cms/templates/cms_menu.html).

Goal

Remove support for a nav menu item to be a link and have a dropdown.

Requirements

  1. CMS navigation must not support top-level link click and dropdown simultaneously.
    1. This must be true for CMS pages.*
    2. This must be true for Portal pages (like Public Data).*
    3. This must be true for User Guide site (like [Frontera User Guide]).*†

* [This clarification was added] on 2021-08-11 during CEPv2 Testing Session.
No CEPv2 website yet has dropdown menu and User Guide, so this requires special testing.

Background

This is a feature that @tacc-wbomar added that now needs to be removed.

Direction

To remove ad hoc per site…

Warning: This is not a long-term solution.
Caveat: This fix does not work on Portal pages, like Public Data.

The long-term solution is that the template markup should not create a link (because Design does forbids a page that both is a parent of pages and has its own content).

Add this snippet to the footer:

NAME: GH-129: CSS: Temp. Fix to Remove Dropdown Nav Link Support
HTML:

<style type="text/css">
/* Prevent user from functional hover and click on dropdown nav link */
/* TODO: After merge and deploy of GH-101 to this site, delete this snippet */
/* FAQ: GH-101 Solves GH-129 "the right way") */
.s-cms-nav .nav-item.dropdown .nav-link a:not(.dropdown-toggle):not(.dropdown-item) {
    pointer-events: none;
}
</style>

SLUG: gh-129-css-temp-fix-to-remove-dropdown-nav-link-support

@wesleyboar wesleyboar added bug Something isn't working tacc effort XS Extra small effort task (~¼ a week) — does not include review time priority ━ Medium priority labels Feb 8, 2021
@wesleyboar wesleyboar added this to the Phase 1 Frontera milestone Feb 12, 2021
@wesleyboar wesleyboar removed the tacc label Feb 12, 2021
@wesleyboar wesleyboar added priority ▲ High priority and removed priority ━ Medium priority labels Mar 31, 2021
@wesleyboar wesleyboar linked a pull request May 13, 2021 that will close this issue
26 tasks
@wesleyboar wesleyboar self-assigned this May 13, 2021
wesleyboar added a commit that referenced this issue May 13, 2021
- Remove now-moot taccsite_custom:frontera-cms search bar font sizes.
- Support CSS custom selectors (known external bug).
- Test CSS custom selectors (known external bug).
- Remove outdated comment from `c-branding`.
- Set `c-logo` image height in component stylesheet.
- Add TODO for `html { font-size: 62.5%; }`
- Add arrow "mixin" (note: using `%-arrow` syntax).
- Redesign header (but not dropdowns and not portal nav).
- Remove now-moot `s-portal-nav` styles.
- Add & Update header env variables for themes.
- Perform "GH-129: Do Not Support CMS Menu Nav Link & Dropdown".
@wesleyboar wesleyboar linked a pull request May 18, 2021 that will close this issue
@wesleyboar wesleyboar changed the title Do Not Support CMS Menu Nav Link & Dropdown Do Not Support CMS Menu Dropdown Nav Link Jun 3, 2021
@wesleyboar wesleyboar added the paused Started but not actively in progress label Aug 26, 2021
@wesleyboar
Copy link
Member Author

Migrated to FP-1235.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working effort XS Extra small effort task (~¼ a week) — does not include review time paused Started but not actively in progress priority ▲ High priority
Projects
None yet
1 participant