Skip to content

Commit

Permalink
GH-191: UNTESTED Use env() in branding_logos, also
Browse files Browse the repository at this point in the history
- Remove global colors import that is redundant on Portal.
- Comment plan to remove global fonts redundant on Portal.
  • Loading branch information
wesleyboar committed Apr 28, 2021
1 parent 0727b05 commit 7de1751
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,16 @@
/* FAQ: Do not use `48.78px`, because Safari only accepts whole numbers */
height: 49px;

background-color: var(--global-color-primary--xx-dark);
color: var(--global-color-primary--xx-light);
border-bottom: 1px solid var(--global-color-primary--normal);
background-color: env(--header-bkgd-color);
color: env(--header-text-color);
border-bottom: 1px solid env(--header-minor-border-color);
}

.branding-seperator {
width: 1px;
height: 100%;
max-height: var(--branding-logo-height);
border-left: solid 1px var(--global-color-primary--xx-light);
border-left: solid 1px env(--header-text-color);
margin: 0 15px;
vertical-align: middle;
}
Expand Down
5 changes: 1 addition & 4 deletions taccsite_cms/static/site_cms/css/src/site.header.css
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,8 @@
/* CAVEAT: This is already imported in `site.css`, but necessary here to
override Portal (which also loads `site.header.css`), so font
variables are unfortunately overwritten 1x in CMS, 2x in Portal */
/* TODO: Find a way to be modular, but not redundant */
/* GH-191: Use `env()` vars for fonts */
@import url("_imports/settings/font.css");
/* NOTE: Portal does not need this, because it has independent copy of these,
but the User Guides do not. This can be removed in Core-CMS PR #192 */
@import url("../../../site_shared/css/src/_imports/settings/color.css");

/* TRUMPS */

Expand Down

0 comments on commit 7de1751

Please sign in to comment.