Task/gh 35 redesign home page #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On prod snippet-based deploy, this must be loaded _before_ site CSS. So, we break it out here ot make that clear when "deploy"-ing.
This was
linked to
issues
Apr 12, 2021
wesleyboar
commented
Apr 16, 2021
Comment on lines
+23
to
+24
| {# FAQ: Common practice but unused, and template is unnecessary long-term #} | ||
| {# {% block page_type_class %}s-home{% endblock page_type_class %} #} |
There was a problem hiding this comment.
Why Unnecessary Logn-Term?
Because the homepage will eventually be build with TACC plugins available for any page. Right now, the homepage is built with Django and Bootstrap plugins that have TACC class names tacked on.
Comment on lines
+11
to
+12
| @import url("../../../../../../taccsite_cms/static/site_cms/css/src/_imports/trumps/s-article-list.css"); | ||
| @import url("../../../../../../taccsite_cms/static/site_cms/css/src/_imports/trumps/s-article-preview.css"); |
There was a problem hiding this comment.
Short-Term vs. Long-Term
- Now, these styles depend on HTML tags from markup built with Django plugins (thus they are "scope" a.k.a.
s-styles, which makes them "trumps" that overwrite any existing styles). - Later, these styles would depend on markup class names only from markup built with TACC plugins (thus they will be "component" a.k.a.
c-styles, which makes them more easily re-usable).
Comment on lines
+5
to
+6
| <link rel="stylesheet" href="{% static 'frontera-cms/css/build/site.css' %}"> | ||
| <link rel="stylesheet" href="{% static 'frontera-cms/css/build/site.header.css' %}"> |
There was a problem hiding this comment.
Why Not Make fullwidth.html Use These?
Because the rest of Frontera's pages are not ready for the redesign changes these bring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies
Overview
These are changes for the homepage that mostly rely on and accompany changes to Core.
Other Details
TACC/Core-CMS#187