Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick: Remove body bkgd warn color for new sites #37

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Quick: Remove body bkgd warn color for new sites #37

merged 1 commit into from
Apr 6, 2021

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Apr 5, 2021 •
edited
Loading

Overview

Remove warning background color from the newest sites' starter CSS.

Also, fix typos and add comment about purpose of this awful background color.

Testing

  1. Follow Test New CMS Site instructions.
  2. (In Step 2 of Test New CMS Site) Set CMS to run as neuronex-cms or protx-cms.
  3. Load a page that uses neuronex-cms or protx-cms's fullwidth.html template.
  4. Ensure background is white.*

* If background is not white, and you are testing with local image on local standalone CMS, be sure you run npm run build.

Resources

  • remote docker image: taccwma/neuronex-cms:0dd0aa4

@wesleyboar
Quick: Remove body bkgd warn color for new sites
5f04289 
Also, fix typos and add comment about purpose of body bkgd warn color.
@wesleyboar wesleyboar mentioned this pull request Apr 5, 2021
Merged
1 task
@wesleyboar wesleyboar merged commit 2ed02d3 into master Apr 6, 2021
@taoteg taoteg deleted the quick/remove-new-site-body-bkgd-warning-color branch April 12, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstijerina rstijerina rstijerina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wesleyboar @rstijerina