Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick/3dem to neuronex #30

Merged
merged 3 commits into from
Mar 24, 2021
Merged

Quick/3dem to neuronex #30

merged 3 commits into from
Mar 24, 2021

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Mar 24, 2021

Overview

  • Remove 3dem-org in favor of neuronex-cms.
  • Remove excess neuronex-cms assets.
  • Update neuronex-cms secrets.

Testing

See #27, but use neuronex-cms.

Notes

History

  1. The neuronex-cms was merged via Neuronex Static Resources #28.
  2. The 3dem-org was merged via FP-947: Add 3Dem as project, include custom assets #27.
  3. @tacc-wbomar noticed the overlap.
  4. This PR chooses the former and resolves the delta.

- Remove 3dem-org directory/project
- Update secrets:
    - Set logo name
    - Point to favicon
    - Enable portal
- Remove cruft images
@wesleyboar wesleyboar requested a review from taoteg March 24, 2021 18:02
Copy link
Collaborator

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for resolving this.

@wesleyboar wesleyboar merged commit 764bcb7 into master Mar 24, 2021
@wesleyboar wesleyboar deleted the quick/3dem-to-neuronex branch March 24, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants