Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favicon Not Loading for Some Templates #81

Closed
wesleyboar opened this issue Sep 22, 2021 · 0 comments · Fixed by #82
Closed

Favicon Not Loading for Some Templates #81

wesleyboar opened this issue Sep 22, 2021 · 0 comments · Fixed by #82
Assignees
@wesleyboar
Labels
bug Something isn't working priority ▲ High priority

Comments

@wesleyboar
Copy link
Member

wesleyboar commented Sep 22, 2021 •
edited
Loading

Overview

The favicon does not on pages with certain templates.

Steps

  1. Ensure favicon is not cached for test—options:

    • ✅ Visit a project URL with a favicon you have not tried to load. — confirmed
    • ❓ Load local site with new URL or port. — unconfirmed
    • ⚠️ Clear your browser's favicon cache — ha ha, good luck

  2. Load CMS using any of these "Project, Template" combinations:

    • A2CPS, Fullwidth
    • A2CPS, Standard
    • Frontera, Home
    • ProTX, Fullwidth
    • ProTX, Standard
    • UTRC, Fullwidth*
    • UTRC, Standard*

    * These are the only sites with a custom favicon. Test others for default (blue square with white star).

  3. See the favicon does not load.
@wesleyboar wesleyboar added bug Something isn't working priority ▲ High priority labels Sep 22, 2021
@wesleyboar wesleyboar self-assigned this Sep 22, 2021
wesleyboar added a commit that referenced this issue Sep 22, 2021
@wesleyboar
GH-81: Fix Favicons Not Loading
f45687c 
Add `super` blocks to `assets_custom` blocks that should have it.
@wesleyboar wesleyboar mentioned this issue Sep 22, 2021
Merged
wesleyboar added a commit that referenced this issue Sep 22, 2021
@wesleyboar
Squashed merge of hotfix/GH-81-fix-favicons-not-loading of the follow…
5718b10 
…ing:

commit f45687c
Author: Wesley Bomar <[email protected]>
Date:   Wed Sep 22 12:24:06 2021 -0500

    GH-81: Fix Favicons Not Loading

    Add `super` blocks to `assets_custom` blocks that should have it.
@wesleyboar wesleyboar mentioned this issue Sep 22, 2021
Closed
wesleyboar added a commit that referenced this issue Sep 22, 2021
@wesleyboar
Merge pull request #82 from TACC/hotfix/GH-81-fix-favicons-not-loading
a1d3edb 
GH-81: Fix Favicons Not Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wesleyboar wesleyboar

Labels
bug Something isn't working priority ▲ High priority
Projects
None yet
Milestone
No milestone
1 participant
@wesleyboar