Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontera: New Fullwidth & Standard Templates #68

Closed
wesleyboar opened this issue Aug 30, 2021 · 0 comments · Fixed by #69
Closed

Frontera: New Fullwidth & Standard Templates #68

wesleyboar opened this issue Aug 30, 2021 · 0 comments · Fixed by #69
Labels
core Propagation from Core enhancement Improvements or additions to existing features feature A new feature or replacement of present feature frontera For frontera-cms project

Comments

@wesleyboar
Copy link
Member

wesleyboar commented Aug 30, 2021 •
edited
Loading

Goal

For Frontera:

  1. Add standard.html template (retain relevant custom assets).
  2. Simplify fullwidth.html template.

Requirements

  1. Rename fullwidth.html template from "Fullwidth" to "Full Width".
  2. Remove unnecessary code from fullwidth.html template.
  3. Remove deprecated templates that are not used.
  4. Match Core changes from:

Background

  1. Standard template added via GH-310: Breadcrumbs & Standard Template Core-CMS#311.
  2. Standard template expected for GH-88: System Specs Plugin Core-CMS#330.
  3. Full Width template clean up via New Fullwidth & Standard Templates Core-CMS#331.
@wesleyboar wesleyboar mentioned this issue Aug 30, 2021
Closed
wesleyboar added a commit that referenced this issue Aug 30, 2021
@wesleyboar
GH-68: Frontera: Rename "Fullwidth" → "Full Width"
9d80d6b
wesleyboar added a commit that referenced this issue Aug 30, 2021
@wesleyboar
GH-68: Frontera: Remove "DEPRECATED Fullwidth"
a2ae12a
wesleyboar added a commit that referenced this issue Aug 30, 2021
@wesleyboar
GH-68: Frontera: Add "Standard" template
8478c95 
- Add to `secrets.py`.
- Add custom assets mini-template.
- Extend Core standard template but with custom assets.
wesleyboar added a commit that referenced this issue Aug 30, 2021
@wesleyboar
GH-68: Frontera: Cleanup "Full Width" template
1f313cc 
- Remove cruft.
- Include custom assets via mini-template (added in 640952b).
wesleyboar added a commit that referenced this issue Aug 30, 2021
@wesleyboar
GH-68: Frontera: Cleanup "Home" template
8e4464f 
- Extend local `fullwidth.html` template.
- Overwrite custom assets block.
- Include custom assets via mini-template (added in 640952b).
@wesleyboar wesleyboar mentioned this issue Aug 30, 2021
Merged
5 tasks
@wesleyboar wesleyboar changed the title New Fullwidth & Standard Templates Frontera: New Fullwidth & Standard Templates Aug 30, 2021
@wesleyboar wesleyboar added frontera For frontera-cms project enhancement Improvements or additions to existing features feature A new feature or replacement of present feature core Propagation from Core labels Aug 30, 2021
wesleyboar added a commit that referenced this issue Aug 30, 2021
@wesleyboar
Squashed merge of task/GH-68-new-fullwidth-standard-templates
5692ac4
wesleyboar added a commit that referenced this issue Aug 30, 2021
@wesleyboar
GH-68: Frontera: Load via static (not staticfiles)
f9edb3f 
- Fix missing load of static tag on fullwidth.
- Update home for deprecation of `{% load staticfiles %}`.¹

¹ See https://stackoverflow.com/a/55929473/11817077.
wesleyboar added a commit that referenced this issue Aug 30, 2021
@wesleyboar
Squashed merge of task/GH-68-new-fullwidth-standard-templates (to fix…
1d11616 
… bug)
wesleyboar added a commit that referenced this issue Aug 30, 2021
@wesleyboar
GH-68: Frontera: Load via static (not staticfiles)
da29706 
- Fix missing load of static tag on fullwidth.
- Update home for deprecation of `{% load staticfiles %}`.¹

¹ See https://stackoverflow.com/a/55929473/11817077.
This was referenced Aug 30, 2021
Closed
Closed
wesleyboar added a commit that referenced this issue Aug 30, 2021
@wesleyboar
GH-68: Frontera: Remove now-superfluous comment
322af3f
wesleyboar added a commit that referenced this issue Aug 30, 2021
@wesleyboar
Merge branch 'main' into task/GH-68-new-fullwidth-standard-templates
aaedb82
wesleyboar added a commit that referenced this issue Sep 29, 2021
@wesleyboar
Merge branch 'main' into task/GH-68-new-fullwidth-standard-templates
3d01e03
wesleyboar added a commit that referenced this issue Oct 7, 2021
@wesleyboar
Merge branch 'main' into task/GH-68-new-fullwidth-standard-templates
3f699d9
wesleyboar added a commit to TACC/Core-CMS that referenced this issue Oct 7, 2021
@wesleyboar
TACC/Core-CMS-Resources#68: Point to submod commit
adbaef8
wesleyboar added a commit to TACC/Core-CMS that referenced this issue Oct 7, 2021
@wesleyboar
TACC/Core-CMS-Resources#68: Submod fix for favicon
43e4a43
wesleyboar added a commit that referenced this issue Oct 7, 2021
@wesleyboar
GH-68: Avoid reproducing hard-to-find favicon bug
9cec504 
See #82.
wesleyboar added a commit that referenced this issue Oct 8, 2021
@wesleyboar
Merged squash of task/GH-68-new-fullwidth-standard-templates
1cf4c8a
wesleyboar added a commit that referenced this issue Oct 14, 2021
@wesleyboar
Merge pull request #69 from TACC/task/GH-68-new-fullwidth-standard-te…
40e4816 
…mplates
wesleyboar added a commit to TACC/Core-CMS that referenced this issue Oct 14, 2021
@wesleyboar
TACC/Core-CMS-Resources#68: Point to submod commit (#377)
4838e7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Propagation from Core enhancement Improvements or additions to existing features feature A new feature or replacement of present feature frontera For frontera-cms project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FP-1238/GH-68: Frontera: Cleanup Templates & Add Standard Template TACC/Core-CMS-Resources
1 participant
@wesleyboar